Skip to content

test: refactor container_inspect_windows_test.go to use Tigron #4714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChengyuZhu6 merged 1 commit into from
Feb 2, 2026
Merged

test: refactor container_inspect_windows_test.go to use Tigron #4714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 76 additions & 26 deletions cmd/nerdctl/container/container_inspect_windows_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,50 +17,100 @@
package container

import (
"encoding/json"
"testing"

"gotest.tools/v3/assert"

"github.com/containerd/nerdctl/mod/tigron/expect"
"github.com/containerd/nerdctl/mod/tigron/test"
"github.com/containerd/nerdctl/mod/tigron/tig"

"github.com/containerd/nerdctl/v2/pkg/inspecttypes/dockercompat"
"github.com/containerd/nerdctl/v2/pkg/testutil"
"github.com/containerd/nerdctl/v2/pkg/testutil/nerdtest"
)

func TestInspectProcessContainerContainsLabel(t *testing.T) {
testContainer := testutil.Identifier(t)
testCase := nerdtest.Setup()

testCase.Setup = func(data test.Data, helpers test.Helpers) {
containerName := testutil.Identifier(t)
data.Labels().Set("containerName", containerName)
helpers.Ensure("run", "-d", "--name", containerName, "--label", "foo=foo", "--label", "bar=bar", testutil.CommonImage, "sleep", nerdtest.Infinity)
nerdtest.EnsureContainerStarted(helpers, containerName)
}

testCase.Cleanup = func(data test.Data, helpers test.Helpers) {
containerName := data.Labels().Get("containerName")
helpers.Anyhow("rm", "-f", containerName)
}

testCase.Command = func(data test.Data, helpers test.Helpers) test.TestableCommand {
containerName := data.Labels().Get("containerName")
return helpers.Command("inspect", containerName)
}

testCase.Expected = func(data test.Data, helpers test.Helpers) *test.Expected {
return &test.Expected{
ExitCode: expect.ExitCodeSuccess,
Output: func(stdout string, t tig.T) {
var dc []dockercompat.Container

base := testutil.NewBase(t)
defer base.Cmd("rm", "-f", testContainer).Run()
err := json.Unmarshal([]byte(stdout), &dc)
assert.NilError(t, err)
assert.Equal(t, 1, len(dc))

base.Cmd("run", "-d", "--name", testContainer, "--label", "foo=foo", "--label", "bar=bar", testutil.NginxAlpineImage).AssertOK()
base.EnsureContainerStarted(testContainer)
inspect := base.InspectContainer(testContainer)
lbs := inspect.Config.Labels
assert.Equal(t, "foo", dc[0].Config.Labels["foo"])
assert.Equal(t, "bar", dc[0].Config.Labels["bar"])
},
}
}

assert.Equal(base.T, "foo", lbs["foo"])
assert.Equal(base.T, "bar", lbs["bar"])
testCase.Run(t)
}

func TestInspectHyperVContainerContainsLabel(t *testing.T) {
if !testutil.HyperVSupported() {
t.Skip("HyperV is not enabled, skipping test")
testCase := nerdtest.Setup()
testCase.Require = nerdtest.HyperV

testCase.Setup = func(data test.Data, helpers test.Helpers) {
containerName := testutil.Identifier(t)
data.Labels().Set("containerName", containerName)
helpers.Ensure("run", "-d", "--name", containerName, "--isolation", "hyperv", "--label", "foo=foo", "--label", "bar=bar", testutil.CommonImage, "sleep", nerdtest.Infinity)
nerdtest.EnsureContainerStarted(helpers, containerName)
}

testContainer := testutil.Identifier(t)

base := testutil.NewBase(t)
defer base.Cmd("rm", "-f", testContainer).Run()
testCase.Cleanup = func(data test.Data, helpers test.Helpers) {
containerName := data.Labels().Get("containerName")
helpers.Anyhow("rm", "-f", containerName)
}

base.Cmd("run", "-d", "--name", testContainer, "--isolation", "hyperv", "--label", "foo=foo", "--label", "bar=bar", testutil.NginxAlpineImage).AssertOK()
base.EnsureContainerStarted(testContainer)
inspect := base.InspectContainer(testContainer)
lbs := inspect.Config.Labels
testCase.Command = func(data test.Data, helpers test.Helpers) test.TestableCommand {
containerName := data.Labels().Get("containerName")
return helpers.Command("inspect", containerName)
}

//check with HCS if the container is ineed a VM
isHypervContainer, err := testutil.HyperVContainer(inspect)
if err != nil {
t.Fatalf("unable to list HCS containers: %s", err)
Comment on lines -58 to -60
Copy link
Copy Markdown
Member

@haytok haytok Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Equivalent processing also needs to be written in Tigron.

Copy link
Copy Markdown
Contributor Author

@JoonsooWon JoonsooWon Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed it
Thanks

testCase.Expected = func(data test.Data, helpers test.Helpers) *test.Expected {
return &test.Expected{
ExitCode: expect.ExitCodeSuccess,
Output: func(stdout string, t tig.T) {
var dc []dockercompat.Container

err := json.Unmarshal([]byte(stdout), &dc)
assert.NilError(t, err)
assert.Equal(t, 1, len(dc))

//check with HCS if the container is ineed a VM
isHypervContainer, err := testutil.HyperVContainer(dc[0])
assert.NilError(t, err)
assert.Equal(t, true, isHypervContainer)

assert.Equal(t, "foo", dc[0].Config.Labels["foo"])
assert.Equal(t, "bar", dc[0].Config.Labels["bar"])
},
}
}

assert.Assert(t, isHypervContainer, true)
assert.Equal(base.T, "foo", lbs["foo"])
assert.Equal(base.T, "bar", lbs["bar"])
testCase.Run(t)
}