test: refactor container_inspect_windows_test.go to use Tigron#4714
Merged
ChengyuZhu6 merged 1 commit intocontainerd:mainfrom Feb 2, 2026
Merged
Conversation
46 tasks
haytok
reviewed
Jan 22, 2026
Comment on lines
55
to
61
| Output: func(stdout string, t tig.T) { | ||
| containerName := data.Labels().Get("containerName") | ||
| inspect := nerdtest.InspectContainer(helpers, containerName) | ||
| lbs := inspect.Config.Labels | ||
| assert.Equal(t, "foo", lbs["foo"]) | ||
| assert.Equal(t, "bar", lbs["bar"]) | ||
| }, |
Member
There was a problem hiding this comment.
Writing nerdctl inspect containerName in the Command section means testing based on the stdout results, which I think is better. WDYT?
Contributor
Author
There was a problem hiding this comment.
I also considered that approach, but I initially kept the previous implementation because of the parsing complexity.
I agree with your point, and I've fixed to use stdout results.
Thanks for the suggestion.
Comment on lines
92
to
98
| Output: func(stdout string, t tig.T) { | ||
| containerName := data.Labels().Get("containerName") | ||
| inspect := nerdtest.InspectContainer(helpers, containerName) | ||
| lbs := inspect.Config.Labels | ||
| assert.Equal(t, "foo", lbs["foo"]) | ||
| assert.Equal(t, "bar", lbs["bar"]) | ||
| }, |
Comment on lines
-58
to
-60
| isHypervContainer, err := testutil.HyperVContainer(inspect) | ||
| if err != nil { | ||
| t.Fatalf("unable to list HCS containers: %s", err) |
Member
There was a problem hiding this comment.
Equivalent processing also needs to be written in Tigron.
Contributor
Author
There was a problem hiding this comment.
I've fixed it
Thanks
JoonsooWon
force-pushed
the
issues_4613_container_inspect_windows_test.go
branch
from
6a3b6e6 to
dafb80c
Compare
Member
|
When you have time, could you retry the CI and review 🙏 |
Member
|
Please rebase on main branch to pickup the changes. |
Signed-off-by: Joonsoo Won <wonjs0116@gmail.com>
JoonsooWon
force-pushed
the
issues_4613_container_inspect_windows_test.go
branch
from
dafb80c to
4519b52
Compare
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related : #4613