feat: unify XR pane interactions - #145
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16ae0fa3ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Focus only on the review fixes: effective rounded/clamped viewport signatures under fractional scrolling, and visible-pane reconciliation/scroll ownership when an active or grabbed pane becomes overflow-hidden. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9877cdea41
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Focus only on hidden-pane grab finalization ordering: meaningful and no-op grabs must finalize exactly once before visible-ID reconciliation clears ownership, without recursive refresh or unrelated pane mutation. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
xr-standardprimary thumbstick with a dead zone and frame-delta scalingCommits
8c13579feat: unify XR pane interactionsa461a64docs: update XR pane controls16ae0fafix: avoid persisting no-op XR grabs9877cdefix: stabilize XR pane scroll statecff26e0fix: finalize hidden XR pane grabsValidation
CI/validatepassed on headcff26e0corepack pnpm --dir packages/webxr exec vitest run test/panel-interaction.test.ts(26 focused tests passed)corepack pnpm --dir packages/webxr exec vitest run test/panel-view.test.ts test/panel-interaction.test.ts(35 focused tests passed)corepack pnpm --filter @codori/webxr test(133 tests passed before the final focused review fix; current CI reruns the complete suite)corepack pnpm --filter @codori/webxr typecheckgit diff --checkcorepack pnpm --filter @codori/webxr lintandcorepack pnpm --filter @codori/webxr build(with the existing Vite large-chunk advisory)Known device-validation boundary
No real controller or hand-tracking headset was available in this environment. Controller profiles/axes, physical intent feel, refresh-rate behavior, direct fingertip contact, native versus synthesized hand events, and status-window policy on device still require the issue's recorded-headset smoke test. The implementation and browser QA do not claim physical headset validation.
Closes #143