feat: add immersive XR status window - #144
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97e1160890
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Focus on the review fixes only: visible Three.js hand-joint lookup for gesture/pinch/direct touch, fallback Menu availability when a controller lacks a recognized menu mapping, and opaque immersive-AR return-to-VR transition availability. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b7bfe8b405
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Focus only on the latest review fixes: status fallback visibility across right-hand-only, eligible left-hand, and left-controller precedence combinations; and idempotent pinch selection/grab cleanup when thumb or index joint tracking drops. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Validation
validatepassed on current head56b8f73(lint, typecheck, test, and build)pnpm --dir packages/webxr exec vitest run test/panel-interaction.test.ts test/status-window-model.test.ts(29 tests passed on follow-up head56b8f73)pnpm --filter @codori/webxr typecheckpnpm --dir packages/webxr exec vitest run test/panel-interaction.test.ts test/status-window-model.test.ts test/xr-capability.test.ts(38 tests passed on review-fix headb7bfe8b)pnpm --filter @codori/webxr test(106 tests passed locally before the final approved duration-only close-cue adjustment)pnpm --filter @codori/webxr lintpnpm --filter @codori/webxr buildpnpm --filter @codori/client typecheckpnpm --filter @codori/client lintKnown device-validation boundary
The browser preview proves canvas layout, colors, typography, animation, and the distinct alpha/additive visual treatments only. Real controller, tracked-hand, screen/gaze, DOM-overlay, reserved-button visibility,
environmentBlendMode, passthrough optics, reference-space reset, audio perception, and seamless VR/AR transition behavior still require the device matrix described inpackages/webxr/README.md; this PR does not claim those headset-specific paths were physically validated.Closes #142