Skip to content

⚡️ Speed up method LuaMap.merge by 6% #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up method LuaMap.merge by 6% #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions client/src/com/aerospike/client/lua/LuaMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,22 +78,34 @@ public LuaMap clone() {
}

public LuaMap merge(LuaMap map2, LuaFunction func) {
HashMap<LuaValue,LuaValue> target = new HashMap<LuaValue,LuaValue>(map.size() + map2.map.size());
target.putAll(map);
// Cache references to avoid repeated field access
final Map<LuaValue,LuaValue> m1 = this.map;
final Map<LuaValue,LuaValue> m2 = map2.map;

// Precompute capacity to avoid rehashing (assumes default load factor 0.75)
int expected = m1.size() + m2.size();
int capacity = (int)(expected / 0.75f) + 1;
HashMap<LuaValue,LuaValue> target = new HashMap<LuaValue,LuaValue>(capacity);
target.putAll(m1);

boolean hasFunc = !(func == null || func.isnil());

for (Entry<LuaValue,LuaValue> entry : map2.map.entrySet()) {
if (hasFunc) {
LuaValue value = map.get(entry.getKey());
if (!hasFunc) {
// Fast path: no merge function -> copy remaining entries in bulk
target.putAll(m2);
}
else {
for (Entry<LuaValue,LuaValue> entry : m2.entrySet()) {
LuaValue key = entry.getKey();
LuaValue value = m1.get(key);

if (value != null) {
Varargs ret = func.invoke(value, entry.getValue());
target.put(entry.getKey(), (LuaValue)ret);
target.put(key, (LuaValue)ret);
continue;
}
target.put(key, entry.getValue());
}
target.put(entry.getKey(), entry.getValue());
}
return new LuaMap(instance, target);
}
Expand Down