Skip to content

feat: add helpful message when pw-test finds no tests [red-125] #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miliberlin merged 2 commits into from
Feb 6, 2026
Merged

feat: add helpful message when pw-test finds no tests [red-125] #1207

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71472d0
feat: add helpful message when pw-test finds no tests [red-125]
miliberlin Feb 4, 2026
587e996
Merge branch 'main' into michelle/red-125-add-include-flag-to-include…
hwartig Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion packages/cli/src/commands/pw-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,8 @@ export default class PwTestCommand extends AuthCommand {
const checkBundles = Object.values(projectBundle.data.check)

if (!checkBundles.length) {
this.log(`Unable to find checks to run`)
this.style.shortError('Unable to find checks to run.')
this.style.shortInfo('Check your Playwright configuration to ensure it targets your test files.')
return
}

Expand Down Expand Up @@ -305,10 +306,15 @@ export default class PwTestCommand extends AuthCommand {
}, links))
})

const noTestsFoundChecks = new Set<string>()

runner.on(Events.CHECK_SUCCESSFUL,
(sequenceId: SequenceId, check, result, testResultId, links?: TestResultsShortLinks) => {
if (result.hasFailures) {
process.exitCode = 1
if (noTestsFoundChecks.has(check.logicalId)) {
this.style.shortInfo('Check your Playwright configuration to ensure it targets your test files.')
}
}

reporters.forEach(r => r.onCheckEnd(sequenceId, {
Expand All @@ -326,6 +332,9 @@ export default class PwTestCommand extends AuthCommand {
hasFailures: true,
runError: message,
}))
if (message.includes('No tests found')) {
this.style.shortInfo('Check your Playwright configuration to ensure it targets your test files.')
}
process.exitCode = 1
})
runner.on(Events.RUN_FINISHED, () => reporters.forEach(r => r.onEnd()))
Expand All @@ -335,6 +344,10 @@ export default class PwTestCommand extends AuthCommand {
})
runner.on(Events.STREAM_LOGS, (check: any, sequenceId: SequenceId, logs) => {
reporters.forEach(r => r.onStreamLogs(check, sequenceId, logs))
const hasNoTestsFound = logs.some((log: { message: string }) => log.message?.includes('No tests found'))
Copy link
Copy Markdown
Contributor

@hwartig hwartig Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels quite brittle and I can already see us forgetting to update the message in both places, but I don't have a better solution that would be as easy to implement. 🤷

if (hasNoTestsFound) {
noTestsFoundChecks.add(check.logicalId)
}
})
await runner.run()
}
Expand Down