feat: add helpful message when pw-test finds no tests [red-125] #1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pw-test encounters "No tests found", display a helpful hint suggesting to check the Playwright configuration to ensure it targets the test files. Co-Authored-By: Claude Opus 4.5 <[email protected]>
miliberlin
changed the title
miliberlin
force-pushed
the
michelle/red-125-add-include-flag-to-include-specific-directories-when-using
branch
from
e284aab to
71472d0
Compare
…-specific-directories-when-using
hwartig
approved these changes
Feb 6, 2026
| }) | ||
| runner.on(Events.STREAM_LOGS, (check: any, sequenceId: SequenceId, logs) => { | ||
| reporters.forEach(r => r.onStreamLogs(check, sequenceId, logs)) | ||
| const hasNoTestsFound = logs.some((log: { message: string }) => log.message?.includes('No tests found')) |
Contributor
There was a problem hiding this comment.
This feels quite brittle and I can already see us forgetting to update the message in both places, but I don't have a better solution that would be as easy to implement. 🤷
miliberlin
deleted the
michelle/red-125-add-include-flag-to-include-specific-directories-when-using
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pw-testencounters "No tests found", display a helpful hint suggesting to check the Playwright configurationTest plan
pw-testwith a Playwright config pointing to a non-existent test directory