Repository navigation
chore: override undici to ^7.29.1 for CVE fixes - #305
Merged
Merged
Conversation
aakashmandavilli96
force-pushed
the
fix/cve-undici-7.29.1
branch
from
October 5, 2026 21:47
98e47f7 to
f828332
Compare
aakashmandavilli96
changed the title
Bumps the undici dependency override from ^7.29.0 to ^7.29.1, the 7.x release that backports fixes for the undici advisories flagged by the Security Scan (CVE-2026-13697, CVE-2026-84961, CVE-2026-14643, CVE-2026-19534, CVE-2026-84933, CVE-2026-85014). Staying on the 7.x line avoids the undici 8.x major, which @vscode/proxy-agent (undici's consumer) does not accept. Updates the finding-override-undici patch, both sagemaker.series package-lock overrides (root and remote), and the OSS attribution. Engines constraint is unchanged (node >=20.18.1).
aakashmandavilli96
force-pushed
the
fix/cve-undici-7.29.1
branch
from
October 5, 2026 21:49
f828332 to
79ab6f5
Compare
aakashmandavilli96
changed the title
austinjang2
approved these changes
Oct 5, 2026
ghost
approved these changes
Oct 5, 2026
skazantsev
approved these changes
Oct 6, 2026
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description of Changes
Bumps the
undicidependency override from^7.29.0to^7.29.1to resolve undici advisories flagged by the security scan (6 CVEs, 2 Critical): CVE-2026-13697, CVE-2026-84961, CVE-2026-14643, CVE-2026-19534, CVE-2026-84933, CVE-2026-85014.undici 7.29.1 is the 7.x release that backports fixes for these advisories (every advisory range is
< 7.29.1). Staying on the 7.x line is deliberate: the fix also exists on undici 8.x, but 8.x is a semver-major and@vscode/proxy-agent(undici's consumer, including its latest release) requiresundici ^7.2.0and does not accept 8.x. This follows the existing override inpatches/common/finding-override-undici.diff.Changed:
patches/common/finding-override-undici.diff— override target^7.29.0→^7.29.1(direct, global,remote/package.json@global)package-lock-overrides/sagemaker.series/package-lock.jsonand.../remote/package-lock.json— undici version/resolved/integrity + root dep specLICENSE-THIRD-PARTYandoverrides/LICENSE-THIRD-PARTY— OSS attribution 7.29.0 → 7.29.1The
enginesconstraint is unchanged (node >=20.18.1). The other scan-flagged packages (tar, shell-quote, ip-address) already carry fixed versions on this branch via their existingfinding-override-*.diffpatches.Testing
npm auditreports 0 vulnerabilities for undici 7.29.1, where 7.29.0 reported 10 HIGH advisories (all with range< 7.29.1). Lock-override regeneration (scripts/update-package-locks.sh) and the SageMaker unit tests should run in CI, as they require preparedcode-editor-srcnot present in a plain clone.Screenshots/Videos
N/A — dependency version bump, no user-visible change.
Additional Notes
Stopgap override per the patch header convention ("Remove when upstream Code-OSS updates undici to >= 7.29.1"). The pending
sagemakerCodeEditorVersion1.10.2 already on this branch carries this fix; no further version bump is included here.Backporting
Targets the
1.2release branch. Ifmainalso pins undici at^7.29.0, a sibling PR tomainshould follow.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.