Repository navigation
[1.2] fix: update undici in dependent override patches after #305 - #310
Merged
Merged
Conversation
This was referenced Oct 6, 2026
skazantsev
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description of Changes
Follow-up to #305. #305 changed the undici override to
^7.29.1but did not update the patches that apply after it in the series. Their removed lines still expect"undici": "^7.29.0", so the series no longer applies on the1.2head:finding-override-form-data.diff— hunk fails onpackage.jsonfinding-override-tar.diff— hunk fails onremote/package.jsonThis PR updates those lines to
^7.29.1. It also bumps undici in the web-server, web-embedded and web-embedded-with-terminal lock files, which #305 did not update.Testing
Applied the
package.jsonhunks of every patch in all four*.seriesfiles (sagemaker, web-server, web-embedded, web-embedded-with-terminal) against the upstreampackage.json/remote/package.jsonat the pinnedthird-party-srccommit withpatch -F0: all apply cleanly and produceundici@^7.29.1. Lock files validated as JSON; 7.29.1 integrity matchesnpm view undici@7.29.1 dist.integrity. Full build runs viabuild-targets. Before this fix, the sagemaker series fails on form-data.diff and tar.diff.Screenshots/Videos
N/A — dependency version bump, no user-visible change.
Additional Notes
This blocks the 1.2.3 release.
Backporting
1.2only. Themain/1.1/1.0backports already include this fix.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.