Skip to content

Only pull license for selected tests and publishing container #37827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 1 commit into from
Mar 11, 2026
Merged

Only pull license for selected tests and publishing container #37827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/gradle-command-self-hosted-action/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,5 @@ runs:
rm ~/.m2/settings.xml
fi
./gradlew ${{ inputs.gradle-command }} --max-workers=${{ inputs.max-workers }} --continue --no-daemon \
-Dorg.gradle.jvmargs=-Xms2g -Dorg.gradle.jvmargs=-Xmx6g -Dorg.gradle.vfs.watch=false -Pdocker-pull-licenses \
-Dorg.gradle.jvmargs=-Xms2g -Dorg.gradle.jvmargs=-Xmx6g -Dorg.gradle.vfs.watch=false \
${{ inputs.arguments }}
3 changes: 2 additions & 1 deletion .github/workflows/beam_PreCommit_GoPortable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,5 @@ jobs:
- name: Run goPortablePreCommit script
uses: ./.github/actions/gradle-command-self-hosted-action
with:
gradle-command: :goPortablePreCommit
gradle-command: :goPortablePreCommit
arguments: -Pdocker-pull-licenses
1 change: 1 addition & 0 deletions .github/workflows/beam_PreCommit_Java_Examples_Dataflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ jobs:
arguments: |
-PdisableSpotlessCheck=true \
-PdisableCheckStyle=true \
-Pdocker-pull-licenses \
- name: Archive JUnit Test Results
uses: actions/upload-artifact@v4
if: ${{ !success() }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/beam_PreCommit_Java_Examples_Dataflow_Java21.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ jobs:
-PtestJavaVersion=21 \
-PskipCheckerFramework \
-Pjava21Home=$JAVA_HOME_21_X64 \
-Pdocker-pull-licenses \
max-workers: 12
- name: Archive JUnit Test Results
uses: actions/upload-artifact@v4
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/beam_PreCommit_PythonDocker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,4 +102,5 @@ jobs:
gradle-command: :sdks:python:container:py${{steps.set_py_ver_clean.outputs.py_ver_clean}}:docker
arguments: |
-Pposargs=apache_beam/dataframe/ \
-PpythonVersion=${{ matrix.python_version }}
-PpythonVersion=${{ matrix.python_version }} \
-Pdocker-pull-licenses
1 change: 1 addition & 0 deletions .github/workflows/beam_Publish_Beam_SDK_Snapshots.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,3 +127,4 @@ jobs:
-Pdocker-tag-list=${{ github.sha }},${BEAM_VERSION}${LATEST_TAG} \
-Pcontainer-architecture-list=arm64,amd64 \
-Ppush-containers \
-Pdocker-pull-licenses
6 changes: 4 additions & 2 deletions .github/workflows/beam_Publish_Docker_Snapshots.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,13 @@ jobs:
gradle-command: :runners:spark:3:job-server:container:dockerPush
arguments: |
-Pdocker-repository-root=gcr.io/apache-beam-testing/beam_portability \
-Pdocker-tag-list=${{ github.sha }}${LATEST_TAG}
-Pdocker-tag-list=${{ github.sha }}${LATEST_TAG} \
-Pdocker-pull-licenses
- name: run Publish Docker Snapshots script for Flink 1.17
uses: ./.github/actions/gradle-command-self-hosted-action
with:
gradle-command: :runners:flink:1.17:job-server-container:dockerPush
arguments: |
-Pdocker-repository-root=gcr.io/apache-beam-testing/beam_portability \
-Pdocker-tag-list=${{ github.sha }}${LATEST_TAG}
-Pdocker-tag-list=${{ github.sha }}${LATEST_TAG} \
-Pdocker-pull-licenses
2 changes: 1 addition & 1 deletion sdks/python/container/license_scripts/pull_licenses_py.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def copy_license_files(dep):
@retry(
reraise=True,
wait=wait_exponential(multiplier=2),
stop=stop_after_attempt(10))
stop=stop_after_attempt(8))
Copy link
Copy Markdown
Contributor Author

@Abacn Abacn Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2^(10-1)=8.5 minutes wait, effectively causing workflow timeout. Not quite useful at this point.

def pull_from_url(dep, configs):
'''
:param dep: name of a dependency
Expand Down
Loading