Only pull license for selected tests and publishing container#37827
Only pull license for selected tests and publishing container#37827Abacn merged 1 commit intoapache:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request optimizes the process of pulling licenses within the CI/CD pipeline by making license fetching more targeted and efficient. It adjusts a GitHub Action to only trigger license pulling for specific scenarios, such as selected tests and publishing containers, rather than as a default for all Gradle commands. Additionally, it reduces the number of retry attempts for network-dependent license fetching, aiming to improve build times and potentially mitigate issues related to network throttling or temporary service unavailability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Release candidates explicitly set the flag: and it's also enabled when beam/sdks/java/container/common.gradle Line 111 in 9829d6d beam/sdks/python/container/common.gradle Line 124 in 9829d6d beam/sdks/go/container/build.gradle Line 42 in 9829d6d etc |
| @@ -75,7 +75,7 @@ def copy_license_files(dep): | |||
| @retry( | |||
| reraise=True, | |||
| wait=wait_exponential(multiplier=2), | |||
| stop=stop_after_attempt(10)) | |||
| stop=stop_after_attempt(8)) | |||
There was a problem hiding this comment.
2^(10-1)=8.5 minutes wait, effectively causing workflow timeout. Not quite useful at this point.
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
Merging to mitigate traffic of license pull, as https://github.com/apache/beam/actions/runs/22961218532/job/66652090517?pr=37827 is green. The change isn't effective on PR run. |
|
Merged and monitoring test status |
Please add a meaningful description for your change here
Apparently GitHub might have throttled / denylisted self-hosted GitHub Action runner
This should bring most PreCommit/PostCommit that building container back to green
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.