Skip to content

GH-50859: [C++] Build JsonWriter when Parquet is enabled without JSON #50900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Krishnanand-G wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

GH-50859: [C++] Build JsonWriter when Parquet is enabled without JSON #50900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion cpp/src/arrow/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1070,6 +1070,18 @@ else()
set(ARROW_IPC_TARGET_STATIC)
endif()

# Parquet (LogicalType::ToJSON, encryption, geospatial) calls JsonWriter
# even when ARROW_JSON=OFF. Keep the writer in its own object library.
if(ARROW_JSON OR ARROW_PARQUET)
arrow_add_object_library(ARROW_JSON_WRITER json/json_writer_internal.cc)
foreach(ARROW_JSON_WRITER_TARGET ${ARROW_JSON_WRITER_TARGETS})
target_link_libraries(${ARROW_JSON_WRITER_TARGET} PRIVATE arrow::simdjson)
endforeach()
else()
set(ARROW_JSON_WRITER_TARGET_SHARED)
set(ARROW_JSON_WRITER_TARGET_STATIC)
endif()

if(ARROW_JSON)
arrow_add_object_library(ARROW_JSON
extension/fixed_shape_tensor.cc
Expand All @@ -1081,7 +1093,6 @@ if(ARROW_JSON)
json/chunker.cc
json/converter.cc
json/from_string.cc
json/json_writer_internal.cc
json/object_parser.cc
json/parser.cc
json/reader.cc)
Expand Down Expand Up @@ -1195,6 +1206,7 @@ add_arrow_lib(arrow
${ARROW_IO_TARGET_SHARED}
${ARROW_IPC_TARGET_SHARED}
${ARROW_JSON_TARGET_SHARED}
${ARROW_JSON_WRITER_TARGET_SHARED}
${ARROW_MEMORY_POOL_TARGET_SHARED}
${ARROW_ORC_TARGET_SHARED}
${ARROW_TELEMETRY_TARGET_SHARED}
Expand All @@ -1211,6 +1223,7 @@ add_arrow_lib(arrow
${ARROW_IO_TARGET_STATIC}
${ARROW_IPC_TARGET_STATIC}
${ARROW_JSON_TARGET_STATIC}
${ARROW_JSON_WRITER_TARGET_STATIC}
${ARROW_MEMORY_POOL_TARGET_STATIC}
${ARROW_ORC_TARGET_STATIC}
${ARROW_TELEMETRY_TARGET_STATIC}
Expand Down