GH-50859: [C++] Build JsonWriter when Parquet is enabled without JSON - #50900
Open
Krishnanand-G wants to merge 1 commit into
Open
GH-50859: [C++] Build JsonWriter when Parquet is enabled without JSON#50900Krishnanand-G wants to merge 1 commit into
Krishnanand-G wants to merge 1 commit into
Conversation
…t JSON json_writer_internal.cc lived in the ARROW_JSON object library, so ARROW_JSON=OFF left parquet tools with undefined JsonWriter symbols. Signed-off-by: Krishnanand G <118352827+Krishnanand-G@users.noreply.github.com>
|
|
Reranko05
reviewed
Aug 18, 2026
Reranko05
left a comment
Reranko05
left a comment
Collaborator
There was a problem hiding this comment.
LGTM for the approach. However, the CI that originally caught this issue was external to Arrow. Could you please build locally with ARROW_JSON=OFF and ARROW_PARQUET=ON to verify the fix?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
#50859: with
ARROW_JSON=OFF, parquet tools fail to link:undefined reference to arrow::json::JsonWriter::GetString() constjson_writer_internal.ccwas only compiled into theARROW_JSONobject library. Parquet still callsJsonWriterfromtypes.cc, encryption, and geospatial helpers.ARROW_PARQUETalready pulls in simdjson, so the writer can live outside the JSON feature flag.What changes are included in this PR?
Move
json/json_writer_internal.ccinto a smallARROW_JSON_WRITERobject library, built whenARROW_JSONorARROW_PARQUETis on, and link it into libarrow.Are these changes tested?
I did not run a full
ARROW_JSON=OFF+ Parquet extra build on this machine. The failure is a missing object in libarrow; Arrow CI (including jobs that setARROW_JSON=OFF) is the check I am relying on.Are there any user-facing changes?
No.