Skip to content

[Refactor] Use declarative map in calculateLocalChecksums #8613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Refactor] Use declarative map in calculateLocalChecksums #8613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions packages/theme/src/cli/utilities/theme-uploader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,21 +396,13 @@ function createBatches<T extends {size: number}>(files: T[]): T[][] {
}

function calculateLocalChecksums(localThemeFileSystem: ThemeFileSystem): ChecksumWithSize[] {
const checksums: ChecksumWithSize[] = []

localThemeFileSystem.files.forEach((file, key) => {
return Array.from(localThemeFileSystem.files.entries()).map(([key, file]) => ({
key,
checksum: file.checksum,
// Text files: use UTF-8 byte count
// Binary files: use base64 length
const size = file.value ? Buffer.byteLength(file.value, 'utf8') : (file.attachment?.length ?? 0)

checksums.push({
key,
checksum: file.checksum,
size,
})
})

return checksums
size: file.value ? Buffer.byteLength(file.value, 'utf8') : (file.attachment?.length ?? 0),
}))
}

async function uploadBatch(
Expand Down