[Refactor] Use declarative map in calculateLocalChecksums - #8613
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Replace the forEach-and-push accumulation with a direct map over the theme file system entries. Behavior is unchanged: Map iteration order is preserved and the size computation is identical. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
calculateLocalChecksumsbuilds its result by declaring an empty array, iterating the theme file system withforEach, and pushing one object per entry. The accumulator and the push obscure what the function actually does, which is a straightforward one-to-one transformation of file system entries into checksum records.WHAT is this pull request doing?
Rewrites
calculateLocalChecksumsinpackages/theme/src/cli/utilities/theme-uploader.tsto map directly over the file system entries instead of accumulating into a local array.Behavior is unchanged.
Array.from(map.entries()).map(...)visits entries in the same insertion order asMap.prototype.forEach, and thesizeexpression is carried over verbatim. The comment explaining the text-versus-binary size calculation stays attached to that line.How to manually test your changes?
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add