Skip to content

fix: [PromptRegistry] byte[] to File on uploads #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rpanackal merged 8 commits into from
May 7, 2026
+15 −4
Merged

fix: [PromptRegistry] byte[] to File on uploads #833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ee2de82
Fix prompt template test
newtork Apr 21, 2026
118fdc2
Formatting
bot-sdk-js Apr 21, 2026
e3489ca
Merge branch 'main' into fix/import-prompt-template
rpanackal May 6, 2026
0584d6b
Regenerate prompt registry module
rpanackal May 6, 2026
f8055ec
Update release notes
rpanackal May 6, 2026
1987fd0
minor
rpanackal May 6, 2026
558edc3
Pin openapi-generator to 7.21.0 to handle regression
rpanackal May 7, 2026
8174273
Merge branch 'main' into fix/import-prompt-template
Jonas-Isr May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...registry/src/main/java/com/sap/ai/sdk/prompt/registry/client/OrchestrationConfigsApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import com.sap.cloud.sdk.services.openapi.apache.apiclient.BaseApi;
import com.sap.cloud.sdk.services.openapi.apache.apiclient.Pair;
import com.sap.cloud.sdk.services.openapi.apache.core.OpenApiRequestException;
import java.io.File;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
Expand Down Expand Up @@ -432,7 +433,7 @@ public OrchestrationConfigGetResponse getOrchestrationConfigByUuid(
*/
@Nonnull
public OrchestrationConfigPostResponse importOrchestrationConfig(
@Nullable final String aiResourceGroup, @Nullable final byte[] _file)
@Nullable final String aiResourceGroup, @Nullable final File _file)
throws OpenApiRequestException {

// create path and map variables
Expand Down
3 changes: 2 additions & 1 deletion ...ompt-registry/src/main/java/com/sap/ai/sdk/prompt/registry/client/PromptTemplatesApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import com.sap.cloud.sdk.services.openapi.apache.apiclient.BaseApi;
import com.sap.cloud.sdk.services.openapi.apache.apiclient.Pair;
import com.sap.cloud.sdk.services.openapi.apache.core.OpenApiRequestException;
import java.io.File;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
Expand Down Expand Up @@ -448,7 +449,7 @@ public PromptTemplateGetResponse getPromptTemplateByUuid(@Nonnull final UUID pro
public PromptTemplatePostResponse importPromptTemplate(
@Nullable final String aiResourceGroup,
@Nullable final String aiResourceGroupScope,
@Nullable final byte[] _file)
@Nullable final File _file)
throws OpenApiRequestException {

// create path and map variables
Expand Down
1 change: 1 addition & 0 deletions docs/release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
### 🔧 Compatibility Notes

- [Document Grounding] `getAllPipelines()` has additional nullable parameter `metadataConfigId`.
- [Prompt Registry] The `importPromptTemplate` and `importOrchestrationConfig` accepts `File` instead of `byte[]` to propagate file name in `Content-Disposition` header.

### ✨ New Functionality

Expand Down
10 changes: 9 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
<maven.compiler.proc>full</maven.compiler.proc>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.build.outputTimestamp>2025-04-03T13:23:00Z</project.build.outputTimestamp>
<cloud-sdk.version>5.29.0</cloud-sdk.version>
<cloud-sdk.version>5.30.0</cloud-sdk.version>
<junit-jupiter.version>6.0.3</junit-jupiter.version>
<wiremock.version>3.13.2</wiremock.version>
<assertj-core.version>3.27.7</assertj-core.version>
Expand Down Expand Up @@ -286,6 +286,14 @@
<groupId>com.sap.cloud.sdk.datamodel</groupId>
<artifactId>openapi-generator-maven-plugin</artifactId>
<version>${cloud-sdk.version}</version>
<dependencies>
<!-- Handle regression in 7.22.0 -->
<dependency>
<groupId>org.openapitools</groupId>
<artifactId>openapi-generator</artifactId>
<version>7.21.0</version>
</dependency>
</dependencies>
Comment on lines +290 to +296
Copy link
Copy Markdown
Member

@rpanackal rpanackal May 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.22.0 brings in a regression on generated mode classes.

Image Image

String (before) is now generated as TrckExecutionId. TrckExecutionId has a schema in spec and is simply a string container. Previously, such string container schemas were resolved to inner String for simplicity.

The resolution is breaking at the moment and there is no equivalent model class generated.

Copy link
Copy Markdown
Member

@rpanackal rpanackal May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related BLI: https://github.com/SAP/ai-sdk-java-backlog/issues/396

</plugin>
<plugin>
<groupId>org.openapitools</groupId>
Expand Down
2 changes: 1 addition & 1 deletion ...ode/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/PromptRegistryController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ PromptTemplateListResponse history() {

@GetMapping("/importTemplate")
PromptTemplatePostResponse importTemplate() throws IOException {
val template = new ClassPathResource("prompt-template.yaml").getContentAsByteArray();
val template = new ClassPathResource("prompt-template.yaml").getFile();
return promptClient.importPromptTemplate("default", null, template);
}

Expand Down
Loading