fix: [PromptRegistry] byte[] to File on uploads#833
Open
Conversation
rpanackal
changed the title
byte[] to File on uploads
rpanackal
changed the title
byte[] to File on uploadsbyte[] to File on uploads
rpanackal
reviewed
May 7, 2026
Comment on lines
+290
to
+296
| <!-- Handle regression in 7.22.0 --> | ||
| <dependency> | ||
| <groupId>org.openapitools</groupId> | ||
| <artifactId>openapi-generator</artifactId> | ||
| <version>7.21.0</version> | ||
| </dependency> | ||
| </dependencies> |
Member
There was a problem hiding this comment.
7.22.0 brings in a regression on generated mode classes.
String (before) is now generated as TrckExecutionId. TrckExecutionId has a schema in spec and is simply a string container. Previously, such string container schemas were resolved to inner String for simplicity.
The resolution is breaking at the moment and there is no equivalent model class generated.
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See diff:
filenamedefinitionCurrently the generated code will not offer that since internally it uses
ByteArrayBodyinstead ofFileBody.The latter will add a
filenamereference.Currently the workaround is to use
Fileinstead ofbyte[].Update 7, May
Edit: This PR now holds the actual fix. Earlier, it served as an example for what the generated code should like.
Now, since the latest cloud sdk release (5.30.0), we have regenerated the prompt-registry module.