Fixes: eslint semicolons + MemoryHistory failing test#28
Open
Rendez wants to merge 2 commits intoReactTraining:masterfrom
Open
Fixes: eslint semicolons + MemoryHistory failing test#28Rendez wants to merge 2 commits intoReactTraining:masterfrom
Rendez wants to merge 2 commits intoReactTraining:masterfrom
Conversation
added 2 commits
May 30, 2018 16:52
Both Browser and History shares the first step of the ReplaceChangesTheKey sequence. The expectation to match the key prop is different for Memory since it creates a first initial entry which contains a value other than undefined. Checking if entries is part of the returned history objects is now used to distinguish one history object type from another and write a working expecation match object.
Rendez
changed the title
Rendez
changed the title
This was referenced May 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.