Skip to content

Migrate codebase to React 16-compatible lifecycles#30

Open
Rendez wants to merge 1 commit intoReactTraining:masterfrom
researchgate:feature/react-16-compat
Open

Migrate codebase to React 16-compatible lifecycles#30
Rendez wants to merge 1 commit intoReactTraining:masterfrom
researchgate:feature/react-16-compat

Conversation

@Rendez
Copy link
Copy Markdown

@Rendez Rendez commented May 31, 2018

  1. Uses Lifecycles from 16.3 to guarantee future compatibility.
  2. History objects are only created if there's an existing DOM in the runtime: this gives implementors the chance to skip initializing history on runtimes without DOM polyfilling/support, e.g.: a running instance Node.js without js-dom.

Depends on #28

In addition history objects are only created if there's an existing DOM in the runtime.

This gives implementors the chance to skip initializing history on runtimes without DOM
polyfilling/support, e.g.: a running instance Node.js without js-dom.
@gitgrimbo
Copy link
Copy Markdown

Hi, will this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants