Decouple R8 from minimization with a deprecated compatibility DSL#2123
Open
Goooler wants to merge 2 commits into
Open
Decouple R8 from minimization with a deprecated compatibility DSL#2123Goooler wants to merge 2 commits into
Goooler wants to merge 2 commits into
Conversation
Goooler
commented
Jul 24, 2026
Goooler
force-pushed
the
g/20260724/explicit-r8-block
branch
2 times, most recently
from
July 24, 2026 04:07
035281f to
1f73574
Compare
Goooler
force-pushed
the
g/20260724/explicit-r8-block
branch
from
July 24, 2026 04:17
1f73574 to
687ca72
Compare
Goooler
force-pushed
the
g/20260724/explicit-r8-block
branch
6 times, most recently
from
July 24, 2026 04:50
2acd1dc to
a473baf
Compare
1 task
Goooler
changed the title
Goooler
force-pushed
the
g/20260724/explicit-r8-block
branch
from
July 24, 2026 04:59
a473baf to
b32b55b
Compare
Goooler
changed the title
Goooler
force-pushed
the
g/20260724/explicit-r8-block
branch
2 times, most recently
from
July 24, 2026 09:33
c24af26 to
24712f9
Compare
Goooler
force-pushed
the
g/20260724/explicit-r8-block
branch
from
July 24, 2026 09:36
24712f9 to
8452ee2
Compare
This was referenced Jul 24, 2026
ZacSweers
reviewed
Jul 24, 2026
ZacSweers
left a comment
ZacSweers
left a comment
Contributor
There was a problem hiding this comment.
I don't really see the value in this as it creates two different minimizing blocks rather than just one that supports different impls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #2077 (comment).