Deprecate minimizeJar property - #2124
Merged
Merged
Conversation
Goooler
changed the title
minimizeJar property
Contributor
There was a problem hiding this comment.
Pull request overview
This PR deprecates the ShadowJar.minimizeJar boolean property to steer users toward explicitly enabling minimization via ShadowJar.minimize(), aligning the DSL direction with recent minimization/R8 decoupling work.
Changes:
- Mark
ShadowJar.minimizeJaras deprecated and adjust internal deprecation suppressions. - Update tests to suppress deprecation warnings when asserting legacy/default properties.
- Add an Unreleased changelog entry documenting the deprecation and Shadow 10 plan.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt | Deprecates minimizeJar and updates related internal wiring / DSL surface. |
| src/test/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowPropertiesTest.kt | Suppresses deprecation warning when asserting minimizeJar default. |
| docs/changes/README.md | Documents the deprecation in the Unreleased section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Goooler
force-pushed
the
g/20260724/deprecate-minimize-jar-flag
branch
from
July 27, 2026 02:59
5e5ecd1 to
8f11065
Compare
Goooler
force-pushed
the
g/20260724/deprecate-minimize-jar-flag
branch
from
July 27, 2026 03:06
8f11065 to
bf393a5
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Goooler
force-pushed
the
g/20260724/deprecate-minimize-jar-flag
branch
from
July 27, 2026 03:08
bf393a5 to
24eee2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns with the modifier of
enableR8.Refs #2123.