Update Serbian translations (Cyrillic & Latin)#60
Open
rammba wants to merge 15 commits intoFlashpointProject:masterfrom
Open
Update Serbian translations (Cyrillic & Latin)#60rammba wants to merge 15 commits intoFlashpointProject:masterfrom
rammba wants to merge 15 commits intoFlashpointProject:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @colin969 @ShadyMedic, thanks for maintaining this magnificent project and preserving Flash features 🚀
As a native Serbian speaker and maintainer of translations for Notepad++, official React docs and other open-source projects I wanted to help with Serbian translation here as well.
I saw that Serbian was introduced few days ago in #59. I've started with the changes directly in the code and then later on noticed that you have Crowdin page.
Since I wasn't sure which one should be done, I've decided to review and improve all the changes in the code and check with you on this PR. I've noticed that some parts from discord and news pages are not present on Crowdin. Few days ago Serbian was 100% translated on Crowdin, now it's 40%, so it's looks like you're still configuring it. Also, there is no official translation guide.
Since there is no integration between Crowdin and this repository, translators won't get contribution on GitHub, which sounds bad for me.
Please let me know what you think about my changes. If you think the other way is better, I can put this to Crowdin as well.