Remove redundant and misleading vanilla nether/end teleport tests#167
Merged
tastybento merged 2 commits intodevelopfrom Mar 8, 2026
Merged
Remove redundant and misleading vanilla nether/end teleport tests#167tastybento merged 2 commits intodevelopfrom
tastybento merged 2 commits intodevelopfrom
Conversation
Merged
…TeleportInVanillaEnd tests Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback from PR #164 regarding Release 4.8.1 changes
Remove redundant and misleading vanilla nether/end teleport tests
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testOnPlayerTeleportInVanillaNetherandtestOnPlayerTeleportInVanillaEndclaimed to test an early-return path ("no border activity") but both mockedinGameWorldtotrueand assertedBukkit::getSchedulerwas invoked — directly contradicting their intent. SinceonPlayerTeleporthas noisIslandNether/isIslandEndchecks, those mocks had no effect, making these tests functionally identical totestOnPlayerTeleportInIslandNether/testOnPlayerTeleportInIslandEnd.Changes
testOnPlayerTeleportInVanillaNetherandtestOnPlayerTeleportInVanillaEnd— the early-return scenario (inGameWorld→false) is already covered bytestOnPlayerTeleportNotInGameWorld💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.