Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The teleport handler called clearUser() (a no-op for ShowWorldBorder) instead of hideBorder(), leaving the old world border active. This caused Bedrock/Geyser clients to enter a restricted interaction state when visiting another island, preventing block breaking until death or relog. - Add hideBorder() call in teleport handler before showing new border - Override clearUser() in ShowWorldBorder to reset world border - Implement refreshView() in ShowWorldBorder to update border on movement Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This release (4.8.1) adds logic to prevent the Border addon from managing world borders and enforcing return-teleports in vanilla (non-island) nether and end worlds. It also adds clearUser and refreshView method overrides to ShowWorldBorder, bumps the version to 4.8.1, adds repository <snapshots> configurations in pom.xml, and adds a CLAUDE.md guidance file.
Changes:
PlayerListener.java: Adds early-return guards inonPlayerTeleportandonPlayerLeaveIslandto skip vanilla nether/end worlds; replacesclearUser-before-guard withhideBorder+clearUser-after-guard; adds debug log messages.ShowWorldBorder.java/Border.java: Adds@Overrides forclearUser/refreshViewinShowWorldBorder; removesUtil.getWorldwrapping inBorder.inGameWorld.- Tests and tooling: New unit tests for the nether/end/vanilla world paths; version bump in
pom.xml; newCLAUDE.mdfile.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/main/java/world/bentobox/border/listeners/PlayerListener.java |
New early-return guards for nether/end-only worlds; hideBorder+clearUser placement moved; debug log messages added |
src/main/java/world/bentobox/border/listeners/ShowWorldBorder.java |
Adds clearUser and refreshView method overrides |
src/main/java/world/bentobox/border/Border.java |
Removes Util.getWorld wrapping from inGameWorld |
src/test/java/world/bentobox/border/listeners/PlayerListenerTest.java |
New tests for vanilla/island nether and end world paths |
src/test/java/world/bentobox/border/listeners/ShowWorldBorderTest.java |
New tests for clearUser and refreshView |
pom.xml |
Version bump to 4.8.1; adds <snapshots> config to repositories |
CLAUDE.md |
New AI assistant guidance file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/world/bentobox/border/listeners/PlayerListener.java
Outdated
Show resolved
Hide resolved
src/main/java/world/bentobox/border/listeners/PlayerListener.java
Outdated
Show resolved
Hide resolved
src/main/java/world/bentobox/border/listeners/PlayerListener.java
Outdated
Show resolved
Hide resolved
src/main/java/world/bentobox/border/listeners/PlayerListener.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
# Conflicts: # src/main/java/world/bentobox/border/listeners/PlayerListener.java
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/world/bentobox/border/listeners/PlayerListener.java
Outdated
Show resolved
Hide resolved
src/main/java/world/bentobox/border/listeners/PlayerListener.java
Outdated
Show resolved
Hide resolved
src/test/java/world/bentobox/border/listeners/PlayerListenerTest.java
Outdated
Show resolved
Hide resolved
|
@tastybento I've opened a new pull request, #165, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@tastybento I've opened a new pull request, #166, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@tastybento I've opened a new pull request, #167, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…TeleportInVanillaEnd tests Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
…return for vanilla worlds Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
…-one Remove redundant and misleading vanilla nether/end teleport tests
|
@tastybento I've opened a new pull request, #168, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Fix vanilla nether/end tests to correctly exercise early-return path in onPlayerLeaveIsland
Add tests for inGameWorld() vanilla nether/end early-return paths
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/test/java/world/bentobox/border/listeners/PlayerListenerTest.java
Outdated
Show resolved
Hide resolved
…st.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.