Add semantic token rules for C# (Roslyn) token types#92
Open
tatsudo wants to merge 1 commit into
Open
Conversation
Roslyn reports an extended token-type legend (field, controlKeyword, recordClass, extensionMethod, ...) beyond the standard LSP set. Without matching rules these tokens are dropped and fall back to tree-sitter-only highlighting. Map the C#-specific types to theme styles; standard types are still covered by Zed's built-in defaults. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roslyn reports an extended semantic-token legend (
field,controlKeyword,recordClass,extensionMethod, ...) beyond the standard LSP types. Without rules for them, those tokens are dropped and C# falls back to tree-sitter-only highlighting (e.g. a private field looks like a local variable).This adds
languages/csharp/semantic_token_rules.jsonmapping the C#-specific types to theme styles. Standard types stay covered by Zed's built-in defaults, so only the Roslyn-specific ones are listed here (same approach the built-in rust/cpp/go/python rules use).Fixes #85. Moved here from zed-industries/zed#60027 per @MrSubidubi's suggestion. Needs zed-industries/zed#60015 (dynamic registration of
textDocument/semanticTokens) to actually deliver the tokens — together they resolve #85.Showcase
Click to view showcase
Before — Roslyn's C# token types aren't mapped, so fields/keywords fall back to tree-sitter (a field looks like a plain variable):
After — fields, constants, control-flow keywords and records get semantic colors: