Fix logic related PBXVariantGroup#1296
Open
takeshi-1000 wants to merge 8 commits intoyonaskolb:masterfrom
Open
Fix logic related PBXVariantGroup#1296takeshi-1000 wants to merge 8 commits intoyonaskolb:masterfrom
takeshi-1000 wants to merge 8 commits intoyonaskolb:masterfrom
Conversation
## SourceGenerator - adapt SourceGenerator to TargetSourceFilterable - refactor variant group logic - add logic where you can add target membership to another target ## PBXProjGenerator - apply. new PBXProjGenerator ## SourceType - add new sourceType
Author
|
I will check ci problem. |
Try to make the logic simpler so that an error does not occur under the Linux environment.
This reverts commit ea402c8.
Author
|
@yonaskolb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed logic in PBXVariantgGroup to meet the requirements of one my project.
stringsresources are not detected correctly #763Description
Previous behavior
SourceGenerator generated a PBXVariantGroup object, created a reference associated with it, and generated a PBXBuildFile object to be added to any target.
This PR
Changed the logic so that the PBXVariantGroupGenerator creates a PBXVariantGroup object and a reference to it, and the SourceGenerator creates a PBXBuildFile object to which targets to add.
It seemed possible to complete it within SourceGenerator as it is now, but I created PBXVariantGroupGenerator for the following background.
・When implementing a function to add a PBXVariantGroup that belongs to one target group to another target, the source code in the SourceGenerator could become complicated and huge, making the code difficult to read. Specifically, the code around the link below is the process of adding targets for other groups.
XcodeGen/Sources/XcodeGenKit/SourceGenerator.swift
Line 541 in bb02e01
Concern
Also Please let us know if you have any other suggestions.
Thanks.