Skip to content

Add ContentNegotiatorMiddleware#16

Closed
vjik wants to merge 6 commits intomasterfrom
content-negotiator
Closed

Add ContentNegotiatorMiddleware#16
vjik wants to merge 6 commits intomasterfrom
content-negotiator

Conversation

@vjik
Copy link
Member

@vjik vjik commented Jan 16, 2026

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 87.09677% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.50%. Comparing base (169ecb4) to head (312bf8d).

Files with missing lines Patch % Lines
src/NotAcceptableRequestHandler.php 0.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              master      #16      +/-   ##
=============================================
- Coverage     100.00%   98.50%   -1.50%     
- Complexity        93      104      +11     
=============================================
  Files             22       24       +2     
  Lines            237      268      +31     
=============================================
+ Hits             237      264      +27     
- Misses             0        4       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik vjik requested a review from a team January 16, 2026 08:13
@vjik vjik added the status:code review The pull request needs review. label Jan 16, 2026
Copy link
Member

@rustamwin rustamwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we generate a 406 response in case of an unacceptable request?

@vjik
Copy link
Member Author

vjik commented Jan 16, 2026

Shouldn't we generate a 406 response in case of an unacceptable request?

Should ContentNegotiatorMiddleware be responsible for this?

@rustamwin
Copy link
Member

If this middleware is used, then yes.

@vjik
Copy link
Member Author

vjik commented Feb 5, 2026

There are no use cases for this middleware.

@vjik vjik closed this Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants