Skip to content

Remove deprecated Checkbox::enclosedByLabel()#391

Open
Mister-42 wants to merge 13 commits into
yiisoft:masterfrom
va108:issue-365
Open

Remove deprecated Checkbox::enclosedByLabel()#391
Mister-42 wants to merge 13 commits into
yiisoft:masterfrom
va108:issue-365

Conversation

@Mister-42

Copy link
Copy Markdown
Contributor

Bugfix

Remove deprecated Checkbox::enclosedByLabel() method. Use labelPlacement() instead.

Q A
Is bugfix? ✔️
New feature?
Breaks BC? ✔️

@codecov

codecov Bot commented Jun 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (f61ccba) to head (690c857).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/Field/Checkbox.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             master    #391   +/-   ##
========================================
  Coverage      0.00%   0.00%           
+ Complexity      815     811    -4     
========================================
  Files            48      48           
  Lines          2716    2708    -8     
========================================
+ Misses         2716    2708    -8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread tests/Field/CheckboxTest.php
@Mister-42

Copy link
Copy Markdown
Contributor Author

Removed the duplicate tests. Thanks for the review!

Comment thread src/Field/Checkbox.php Outdated

@vjik vjik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems, removed tests decrease MSI. Kill muatant.

@Mister-42

Copy link
Copy Markdown
Contributor Author

Updated the data providers instead: DEFAULT yields now don't call uncheckValue(null), keeping the hidden input in the expected output. This covers the code path the removed tests used to cover and should fix the MSI drop.

@vjik

vjik commented Jun 14, 2026

Copy link
Copy Markdown
Member

Updated the data providers instead: DEFAULT yields now don't call uncheckValue(null), keeping the hidden input in the expected output. This covers the code path the removed tests used to cover and should fix the MSI drop.

Now data providers contains too much parameters. Tests looks difficult. Can it be simplified somehow? Maybe instead of edits, add new tests?

@vjik vjik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces a BC break, so it should be merged after other BC-breaking changes in the repository.

@vjik vjik added this to the 2.0 milestone Jun 15, 2026
@vjik vjik added the status:ready for merge The pull request is OK to be merged. label Jun 15, 2026
@vjik
vjik requested a review from a team June 15, 2026 12:38
Comment thread CHANGELOG.md Outdated
Comment thread UPGRADE.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:ready for merge The pull request is OK to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants