Skip to content

Remove check for empty name in markPropertyChanged()#575

Open
Tigrov wants to merge 3 commits into
masterfrom
fix-markPropertyChanged
Open

Remove check for empty name in markPropertyChanged()#575
Tigrov wants to merge 3 commits into
masterfrom
fix-markPropertyChanged

Conversation

@Tigrov
Copy link
Copy Markdown
Member

@Tigrov Tigrov commented May 7, 2026

Q A
Is bugfix? ✔️/❌
New feature?
Breaks BC?
Fixed issues #551

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 35da3c86-b3b3-4840-9e24-5c5d30476780

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-markPropertyChanged

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.69%. Comparing base (e6b78e0) to head (836c562).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #575   +/-   ##
=========================================
  Coverage     99.69%   99.69%           
+ Complexity      663      662    -1     
=========================================
  Files            43       43           
  Lines          1646     1646           
=========================================
  Hits           1641     1641           
  Misses            5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tigrov Tigrov added the status:code review The pull request needs review. label May 7, 2026
@Tigrov Tigrov requested a review from a team May 7, 2026 13:23
…nged

# Conflicts:
#	tests/ActiveRecordTest.php
Copy link
Copy Markdown
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add line to changelog

@Tigrov Tigrov requested a review from vjik May 13, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants