Skip to content

Added support of availabilityPeriod to topic consumer#589

Open
alex268 wants to merge 4 commits intoydb-platform:masterfrom
alex268:master
Open

Added support of availabilityPeriod to topic consumer#589
alex268 wants to merge 4 commits intoydb-platform:masterfrom
alex268:master

Conversation

@alex268
Copy link
Member

@alex268 alex268 commented Feb 13, 2026

No description provided.

@alex268 alex268 requested a review from pnv1 February 13, 2026 10:57
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.45%. Comparing base (1a922ae) to head (fd382f9).

Files with missing lines Patch % Lines
...main/java/tech/ydb/topic/description/Consumer.java 40.00% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #589      +/-   ##
============================================
+ Coverage     63.39%   63.45%   +0.06%     
- Complexity     2487     2491       +4     
============================================
  Files           334      334              
  Lines         13999    14009      +10     
  Branches       1418     1421       +3     
============================================
+ Hits           8874     8890      +16     
+ Misses         4473     4468       -5     
+ Partials        652      651       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for configuring a consumer availabilityPeriod in the Topic client, wiring the new field through the public Consumer model and into the protobuf request mapping, and extending integration tests.

Changes:

  • Add availabilityPeriod to tech.ydb.topic.description.Consumer (builder, proto mapping, equals/hashCode, docs).
  • Serialize availabilityPeriod into YdbTopic.Consumer requests in TopicClientImpl.
  • Add an integration test asserting an invalid combination (important + availabilityPeriod) is rejected; set a test env var in topic/pom.xml.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
topic/src/main/java/tech/ydb/topic/description/Consumer.java Introduces the availabilityPeriod field and builder API; maps it from proto and includes it in equality/hash.
topic/src/main/java/tech/ydb/topic/impl/TopicClientImpl.java Serializes availabilityPeriod into the protobuf consumer message when present.
topic/src/test/java/tech/ydb/topic/impl/YdbTopicsIntegrationTest.java Adds a negative integration test for incompatible consumer options.
topic/pom.xml Configures surefire env var YDB_DOCKER_IMAGE for tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants