Added support of availabilityPeriod to topic consumer#589
Open
alex268 wants to merge 4 commits intoydb-platform:masterfrom
Open
Added support of availabilityPeriod to topic consumer#589alex268 wants to merge 4 commits intoydb-platform:masterfrom
alex268 wants to merge 4 commits intoydb-platform:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #589 +/- ##
============================================
+ Coverage 63.39% 63.45% +0.06%
- Complexity 2487 2491 +4
============================================
Files 334 334
Lines 13999 14009 +10
Branches 1418 1421 +3
============================================
+ Hits 8874 8890 +16
+ Misses 4473 4468 -5
+ Partials 652 651 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR adds support for configuring a consumer availabilityPeriod in the Topic client, wiring the new field through the public Consumer model and into the protobuf request mapping, and extending integration tests.
Changes:
- Add
availabilityPeriodtotech.ydb.topic.description.Consumer(builder, proto mapping, equals/hashCode, docs). - Serialize
availabilityPeriodintoYdbTopic.Consumerrequests inTopicClientImpl. - Add an integration test asserting an invalid combination (
important+availabilityPeriod) is rejected; set a test env var intopic/pom.xml.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| topic/src/main/java/tech/ydb/topic/description/Consumer.java | Introduces the availabilityPeriod field and builder API; maps it from proto and includes it in equality/hash. |
| topic/src/main/java/tech/ydb/topic/impl/TopicClientImpl.java | Serializes availabilityPeriod into the protobuf consumer message when present. |
| topic/src/test/java/tech/ydb/topic/impl/YdbTopicsIntegrationTest.java | Adds a negative integration test for incompatible consumer options. |
| topic/pom.xml | Configures surefire env var YDB_DOCKER_IMAGE for tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
topic/src/test/java/tech/ydb/topic/impl/YdbTopicsIntegrationTest.java
Outdated
Show resolved
Hide resolved
topic/src/test/java/tech/ydb/topic/impl/YdbTopicsIntegrationTest.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.