fix: avoid per-instantiation vtable issues with MinGW GCC#1290
Open
DiamonDinoia wants to merge 1 commit intoxtensor-stack:masterfrom
Open
fix: avoid per-instantiation vtable issues with MinGW GCC#1290DiamonDinoia wants to merge 1 commit intoxtensor-stack:masterfrom
DiamonDinoia wants to merge 1 commit intoxtensor-stack:masterfrom
Conversation
Replace INFO() macro calls with concrete StringContextScope class to work around MinGW GCC generating a unique vtable per template instantiation. INFO() creates ContextScope<Lambda> which triggers this issue; the concrete class has a single vtable definition shared across all instantiations. - Add StringContextScope struct inheriting from doctest::detail::ContextScopeBase - Add make_context_info() helper to create context without template lambdas - Update CHECK_BATCH_EQ, CHECK_SCALAR_EQ, CHECK_VECTOR_EQ macros to use new helper
| #define CHECK_BATCH_EQ(b1, b2) \ | ||
| do \ | ||
| { \ | ||
| auto _ctx1 = ::detail::make_context_info(#b1, b1); \ |
Contributor
There was a problem hiding this comment.
please add a small comment here and below to explain why we're doing something smart :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace INFO() macro calls with concrete StringContextScope class to work around MinGW GCC generating a unique vtable per template instantiation. INFO() creates ContextScope which triggers this issue; the concrete class has a single vtable definition shared across all instantiations.