Repository navigation
Prioritize visible thumbnails and expose real model variants - #152
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc3222a7c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2bb75414ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4f01a79523
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Scrolling past pending model thumbnails could leave the browser working through old entries while visible cards stayed blank. Request and queue only visible cards, discard offscreen queued work, cancel offscreen worker texture waits and ignore stale acknowledgements; returning to a card requests it again.
Expand metadata model families into their actual numbered archive files so all five AlchemySet variations appear with resolvable paths. Retain owning rawcodes in variant search metadata, add direct Definitive Edition model/texture candidates, and keep generic file resolution exact. Invalidate old renderer captures and rebuild the local
war3-modelsource before compile, package, and watch mode sofile:dependencies cannot silently contribute stale renderer code.Companion fixes: normalized renderer RGB and CASC namespace discovery. The library fixes should be available when building this extension. This branch starts from master and excludes the compiler-version PR.
Validation: the linked renderer build ran before watch mode and webpack produced fresh bundles; production packaging, unit tests, lint, host and webview TypeScript checks passed. The affected model, standalone asset, and object browser suites passed (33 tests), including filtering during texture waits and saved-scroll restoration; the full browser suite completed with 122 passes and one 30-second timeout in the unrelated custom-object deletion/reindexing test. That same test passed in isolation with unchanged timeout settings; the full-suite timeout remains a documented local validation limitation. Screenshot-verified all five real AlchemySet variants with loaded thumbnails, and Azerite01's corrected colors in the production viewer.
The viewport-only cancellation policy follows the user's explicit requirement to request only thumbnails in view. AGENTS.md now records it: queued work and worker texture waits are cancelled offscreen, host resolution already in flight settles, and stale replies are ignored before rendering.