Fix PowerShell command substitution argument parsing#6227
Open
Fix PowerShell command substitution argument parsing#6227
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PowerShell argument splitting for space-separated IDs
This PR addresses an issue where WP-CLI commands on Windows PowerShell incorrectly handle space-separated IDs from command substitution.
Problem
$(wp post list --post_type='page' --format=ids)returns IDs as a single string (e.g., "1164 1186")wp post delete $(...)to only process the first ID when the string is cast to intSolution
Added Windows-specific argument splitting logic in
Runner::back_compat_conversions()to detect and split space-separated numeric IDs.Implementation Details
The fix:
Utils\is_windows())/^\d+(\s+\d+)+$/)array_push()with splat operator for better performance with large numbers of IDsChanges
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.