AES asm: Add GCM 8-bit tabl, fixes#10949
Open
SparkiDev wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Code generated by: |
SparkiDev
force-pushed
the
aes_asm_gcm_tables_fixup
branch
from
July 20, 2026 12:19
8c02fe0 to
bdbb161
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10949
Scan targets checked: wolfcrypt-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
Added assembly to do 8-bit-table GCM_gmult_len. Wired it into aes.c and wired small to use C code. Fixed guards around assembly.
SparkiDev
force-pushed
the
aes_asm_gcm_tables_fixup
branch
from
July 20, 2026 22:46
bdbb161 to
1c62d90
Compare
SparkiDev
commented
Jul 20, 2026
Contributor
Author
|
Jenkins: retest this please FIPS FAILED |
SparkiDev
requested review from
wolfSSL-Fenrir-bot
and removed request for
wolfSSL-Fenrir-bot
July 21, 2026 10:46
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10949
Scan targets checked: wolfcrypt-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
No new issues found in the changed files. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added assembly to do 8-bit-table GCM_gmult_len.
Wired it into aes.c and wired small to use C code.
Fixed guards around assembly.
Testing
Regression tested AES assembly for ARM64, ARM32 and Thumb2.