Guard against negative length in BIO, I/O callbacks and PKCS12 PBKDF#10208
Draft
ColtonWilley wants to merge 1 commit intowolfSSL:masterfrom
Draft
Guard against negative length in BIO, I/O callbacks and PKCS12 PBKDF#10208ColtonWilley wants to merge 1 commit intowolfSSL:masterfrom
ColtonWilley wants to merge 1 commit intowolfSSL:masterfrom
Conversation
- src/bio.c: Add BIO self-cycle UAF guard and negative nread/nwrite checks - src/wolfio.c: Add negative sz guards to EmbedSend/EmbedReceive - wolfcrypt/src/pwdbased.c: Add pLen/sLen/totalLen overflow checks in wc_PKCS12_PBKDF_ex
ColtonWilley
force-pushed
the
bio-io-negative-length-checks
branch
from
ac1909e to
e868939
Compare
ColtonWilley
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nread/nwritelengths inwolfSSL_BIO_nread/wolfSSL_BIO_nwriteszinEmbedSendandEmbedReceivepLen/sLen/totalLenoverflow checks inwc_PKCS12_PBKDF_exNote
The PKCS12 parse fix for stale
ci->dataSzbounds (zd21568) is covered by #10172 — this PR is complementary to that fix.