Closed
Conversation
- wolfSSL_i2d_OCSP_REQUEST_bio: save/restore pointer before i2d call that advances it, preventing BIO_write from wrong offset and heap corruption on free - wolfSSL_d2i_OCSP_RESPONSE: remove (unsigned char) cast that truncated pointer advance to 8 bits, breaking responses larger than 255 bytes - wolfSSL_OCSP_CERTID_dup: deep-copy CertStatus to prevent double-free when both original and duplicate are freed - wolfSSL_i2d_OCSP_RESPONSE: add NULL check on response parameter - wolfSSL_i2d_OCSP_REQUEST: advance *data pointer per i2d convention - FreeOCSP: NULL-check ocsp->cm before dereferencing for heap - Fix WOLFSSL_LEAVE strings to match actual function names in wc_CheckCertOcspResponse, GetOcspEntry, GetOcspStatus, CheckOcspResponse, CheckOcspRequest Add test for CERTID dup (double-free confirmed under ASAN without fix) and pointer advancement assertions for d2i_OCSP_RESPONSE callers. Reported in: ZD21469
This only makes an actual difference when FREESCALE_MMCAU is defined (otherwise encrypt and decrypt are the same), but better for clarity still.
…ze newSz in PKCS12_ConcatenateContent
…ertificate chains
Member
Author
|
Claude was trying to pull a commit from a fork for me, it did a bad job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
make checkpasses with default configuration🤖 Generated with Claude Code