Open
Conversation
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10116
Scan targets checked: src, src-bugs, src-compliance, wolfcrypt-api_misuse, wolfcrypt-bugs, wolfcrypt-compliance, wolfcrypt-concurrency, wolfcrypt-portability, wolfcrypt-src
No new issues found in the changed files. ✅
Reported by: Nicholas Carlini <npc@anthropic.com>
Reported by: Nicholas Carlini <npc@anthropic.com>
Reported by: Nicholas Carlini <npc@anthropic.com>
Reported by: Nicholas Carlini <npc@anthropic.com>
Reported by: Nicholas Carlini <npc@anthropic.com>
Contributor
|
only failing subtest is multi-test |
douzzer
requested changes
Apr 3, 2026
Contributor
douzzer
left a comment
There was a problem hiding this comment.
Missing some FIPS gating I suspect, re "Properly reject Ed448 identity public key"
[linuxkm-defaults-all-fips-v6-sanitizer] [35 of 52] [5a573e0c76]
setting up FIPS "v6-linuxkm"...
refreshing fips WCv6.0.0-linuxkm-UPDT-RC3... [caching link to git@github.com... done] done, now at 7756dbea90
setting up FIPS "v6-linuxkm"... refreshing wolfssl WCv6.0.0-linuxkm-UPDT-RC2... done, now at b7220aeb4b
done [fips="WCv6.0.0-linuxkm-UPDT-RC3" (7756dbea90), wolfCrypt="WCv6.0.0-linuxkm-UPDT-RC2" (def685129c)]
configure with sanitizers... real 0m10.090s user 0m6.531s sys 0m4.403s
build... real 0m38.522s user 8m9.887s sys 0m9.403s
fixing FIPS hash in user library... done.
check...FAIL: scripts/unit.test
real 1m23.506s user 2m1.463s sys 0m15.917s
ERROR - tests/api.c line 6719 failed with:
expected: wolfSSL_shutdown(ssl_c) == WOLFSSL_SUCCESS
result: 2 != 1
ERROR - tests/api.c line 34781 failed with:
expected: wc_ed448_import_public_fips(identity, sizeof(identity), &key) != 0
result: 0 == 0
ERROR - tests/api.c line 36066 failed with:
expected: Test failed
result: ret 0
1306: test_pkcs7_decode_encrypted_outputsz : skipped
1307: test_pkcs7_ori_oversized_oid : skipped
1308: test_wolfSSL_Cleanup : passed ( 0.00001)
FAILURES:
1305: test_ed448_rejects_identity_key
End API Tests
Failed/Skipped/Passed/All: 1/443/864/1308
FAIL scripts/unit.test (exit status: 1)
scripts/unit.log tail:
1306: test_pkcs7_decode_encrypted_outputsz : skipped
1307: test_pkcs7_ori_oversized_oid : skipped
1308: test_wolfSSL_Cleanup : passed ( 0.00001)
FAILURES:
1305: test_ed448_rejects_identity_key
End API Tests
Failed/Skipped/Passed/All: 1/443/864/1308
FAIL scripts/unit.test (exit status: 1)
linuxkm-defaults-all-fips-v6-sanitizer fail_analytic_check
failed config: 'EXTRA_CPPFLAGS=-Werror' '--srcdir' '.' '--disable-jobserver' '--enable-option-checking=fatal' '--enable-fips=v6' '--enable-linuxkm-defaults' '--enable-intelasm' '--enable-sp-asm' '--enable-all' '--enable-acert' '--enable-dtls13' '--enable-dtls-mtu' '--enable-dtls-frag-ch' '--enable-dtlscid' '--enable-quic' '--with-sys-crypto-policy' '--disable-srtp' 'CC=gcc-16' 'LDFLAGS=-g -fno-omit-frame-pointer -fsanitize-recover=all -fsanitize=address,pointer-subtract,leak,undefined,float-cast-overflow,float-divide-by-zero,bounds-strict -fsanitize-recover=all ' 'CFLAGS=-DTEST_ALWAYS_RUN_TO_END -Wno-declaration-after-statement -DDEBUG_LINUXKM_PIE_SUPPORT -DWC_SIPHASH_NO_ASM -DWC_DEBUG_CIPHER_LIFECYCLE -g -fno-omit-frame-pointer -fsanitize=address,pointer-subtract,leak,undefined,float-cast-overflow,float-divide-by-zero,bounds-strict -fsanitize-recover=all --param=max-vartrack-size=128000000' 'CPPFLAGS=-DNO_WOLFSSL_CIPHER_SUITE_TEST -pedantic -Wnull-dereference -Wdeclaration-after-statement'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zd21457