Re-enable hostap tests and remove some flaky tests#10058
Open
julek-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Open
Re-enable hostap tests and remove some flaky tests#10058julek-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
julek-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Conversation
ALL should not include NULL ciphersuites. Those need to be enabled explicitly.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates cipher-suite selection behavior and re-enables the hostap/wpa-supplicant CI workflow while removing a set of known-flaky hostap tests.
Changes:
- Mark suites as explicitly set when applying the wolfSSL default cipher list.
- Update OpenSSL interoperability test invocation to explicitly include NULL cipher suites via
ALL:eNULL. - Re-enable the hostap VM GitHub Action on
push/pull_request, update cert regeneration, and drop several flaky hostap test cases from the run list.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/internal.c | Ensures setSuites is set when selecting the wolfSSL default suite list. |
| scripts/openssl.test | Explicitly enables NULL cipher suites in the server cipher list (ALL:eNULL). |
| .github/workflows/hostap-vm.yml | Re-enables CI triggers and adjusts hostap cert regeneration steps. |
| .github/workflows/hostap-files/configs/b607d2723e927a3446d89aed813f1aa6068186bb/tests | Removes specific flaky hostap tests from the executed list. |
| .github/workflows/hostap-files/configs/07c9f183ea744ac04585fb6dd10220c75a5e2e74/tests | Removes specific flaky hostap tests from the executed list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
retest this please |
Contributor
|
retest this please |
Member
Author
|
Jenkins failures appear not related to PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ALL should not include NULL ciphersuites. Those need to be enabled explicitly.