Skip to content

Re-enable hostap tests and remove some flaky tests#10058

Open
julek-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
julek-wolfssl:hostap-ec-generate.sh
Open

Re-enable hostap tests and remove some flaky tests#10058
julek-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
julek-wolfssl:hostap-ec-generate.sh

Conversation

@julek-wolfssl
Copy link
Copy Markdown
Member

ALL should not include NULL ciphersuites. Those need to be enabled explicitly.

ALL should not include NULL ciphersuites. Those need to be enabled explicitly.
Copilot AI review requested due to automatic review settings March 24, 2026 15:31
@julek-wolfssl julek-wolfssl self-assigned this Mar 24, 2026
@julek-wolfssl julek-wolfssl requested a review from douzzer March 24, 2026 15:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates cipher-suite selection behavior and re-enables the hostap/wpa-supplicant CI workflow while removing a set of known-flaky hostap tests.

Changes:

  • Mark suites as explicitly set when applying the wolfSSL default cipher list.
  • Update OpenSSL interoperability test invocation to explicitly include NULL cipher suites via ALL:eNULL.
  • Re-enable the hostap VM GitHub Action on push/pull_request, update cert regeneration, and drop several flaky hostap test cases from the run list.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/internal.c Ensures setSuites is set when selecting the wolfSSL default suite list.
scripts/openssl.test Explicitly enables NULL cipher suites in the server cipher list (ALL:eNULL).
.github/workflows/hostap-vm.yml Re-enables CI triggers and adjusts hostap cert regeneration steps.
.github/workflows/hostap-files/configs/b607d2723e927a3446d89aed813f1aa6068186bb/tests Removes specific flaky hostap tests from the executed list.
.github/workflows/hostap-files/configs/07c9f183ea744ac04585fb6dd10220c75a5e2e74/tests Removes specific flaky hostap tests from the executed list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@douzzer
Copy link
Copy Markdown
Contributor

douzzer commented Mar 24, 2026

retest this please

PRB-FIPS-windows-test-ACVP\testing-cert3389.bat

MD5      test passed!
in my Fips callback, ok = 0, err = -255
message = wolfcrypt FIPS ECDSA Pairwise Agreement Test Failure
hash = B96F13C488A11B1DB9C277008548576F1DEA6EE7C36AF271E834B4ACFD8CFA39
SHA      test failed!
 error L=4534 i=0
all-c89-clang-tidy
FAIL scripts/ocsp-stapling2.test (exit status: 1)
PRB-medium-runtime.txt_12
FAIL scripts/ocsp-stapling_tls13multi.test (exit status: 1)

@douzzer
Copy link
Copy Markdown
Contributor

douzzer commented Mar 24, 2026

retest this please

PRB-medium-runtime.txt_12

FAIL scripts/ocsp-stapling-with-wolfssl-responder.test (exit status: 1)
Build PRB-multi-test-script #10065 completed: ABORTED
PRB-FIPS-windows-test-ACVP\testing-cert3389.bat

MD5      test passed!
in my Fips callback, ok = 0, err = -255
message = wolfcrypt FIPS ECDSA Pairwise Agreement Test Failure
hash = B96F13C488A11B1DB9C277008548576F1DEA6EE7C36AF271E834B4ACFD8CFA39
SHA      test failed!
 error L=4534 i=0

@julek-wolfssl
Copy link
Copy Markdown
Member Author

Jenkins failures appear not related to PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants