Fenrir fixes in wp_kbkdf.c - #465
Open
padelsbach wants to merge 4 commits into
Open
Conversation
padelsbach
commented
Aug 11, 2026
padelsbach
commented
Contributor
- F-8681: check result of param lookup before comparison
- F-2789: add MODE, SEED, and INFO to KBKDF settable params
- F-2243: zeroize hmac/cmac context when freeing
aidangarske
requested changes
Aug 31, 2026
aidangarske
left a comment
aidangarske
left a comment
Member
There was a problem hiding this comment.
Skoll Code Review
Scan type: review
Overall recommendation: REQUEST_CHANGES
Findings: 2 total — 2 posted, 0 skipped
2 finding(s) posted as inline comments (see file-level comments below)
Posted findings
- [High] Cleanup can dispatch through the wrong MAC type —
src/wp_kbkdf.c:541-564 - [Medium] Reset test never resets an initialized MAC —
test/test_kbkdf.c:554-560
Review generated by Skoll
aidangarske
approved these changes
Aug 31, 2026
Member
|
Jenkins retest this please |
Contributor
Author
|
jenkins retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.