Skip to content

Low-severity hardening, input validation, memory safety, and zeroization fixes#441

Merged
padelsbach merged 86 commits into
wolfSSL:masterfrom
aidangarske:fenrir-low-info-batch
Jul 14, 2026
Merged

Low-severity hardening, input validation, memory safety, and zeroization fixes#441
padelsbach merged 86 commits into
wolfSSL:masterfrom
aidangarske:fenrir-low-info-batch

Conversation

@aidangarske

@aidangarske aidangarske commented Jul 10, 2026

Copy link
Copy Markdown
Member 
F-4294, F-2811, F-3165, F-3172, F-4827, F-2804, F-2044, F-3856, F-4550, F-2239, F-6241, F-6679, F-6496, F-6499,
F-6500, F-4086, F-3652, F-5916, F-5202, F-4297, F-5201, F-4295, F-4296, F-5203, F-5180, F-4383, F-4939, F-4696,
F-5200, F-5915, F-4700, F-5178, F-4299, F-4382, F-4385, F-5199, F-4293, F-5181, F-5182, F-5183, F-5193, F-5194,
F-5195, F-5196, F-5187, F-5188, F-5204, F-5192, F-5191, F-5189, F-5190, F-835, F-275, F-3149, F-3151, F-3152, F-3153, 
F-2047, F-3173, F-3170, F-6068, F-6681, F-3167, F-3168, F-3159, F-2795, F-6673, F-515, F-1283, F-1284, F-1285, F-840,
F-6671, F-2805, F-1287, F-177, F-3150, F-5540, F-4538, F-3840, F-4548

aidangarske added 30 commits July 10, 2026 12:48
@aidangarske
F-4294 - Set DH bits after param generation to fix derive overflow
88c2600
@aidangarske
F-2811 - Reject oversized input in RSA X931 sign to prevent overflow
08669a6
@aidangarske
F-3165 - Reject too-short PEM to prevent header compare over-read
e83e6f9
@aidangarske
F-3172 - Zeroize TLS 1.3 HKDF salt secret on free
d79f03d
@aidangarske
F-4827 - Zeroize decrypted PKCS8 key by allocating as PRIVATEKEY_TYPE
5a60712
@aidangarske
F-2804 - Advance index over ECX private key so export buffer is zeroized
018375f
@aidangarske
F-2044 - Zeroize PBKDF1-derived key before free in wp_BufferKeyEncrypt
72932a4
@aidangarske
F-3856 - Zeroize copied AES round keys on dupctx error path
d34066f
@aidangarske
F-4550 - Push restored IV into DES3 state on CBC re-init
5b80bb3
@aidangarske
F-2239 - Fix DH private key byte order for unsigned-integer get_params
0e06fd3
@aidangarske
F-6241 - Initialize Ed25519/Ed448 verify result to fail closed on error
fd347e3
@aidangarske
F-6679 - Fix ML-DSA match reflexivity for single-component keys
a9c7f4b
@aidangarske
F-6496 - Allow RSA key-data size-only query with NULL data buffer
51df566
@aidangarske
F-6499 - Advertise ECX private key as octet string to match import
7d779b7
@aidangarske
F-6500 - Treat DH public key as integer to match import and OpenSSL
5d7b936
@aidangarske
F-4086 - Advertise ECC GROUP_NAME and USE_COFACTOR_ECDH in gettable p…
8d96889 
…arams
@aidangarske
F-3652 - Copy kdfMdName in DH and ECDH dupctx
04ed726
@aidangarske
F-5916 - Guard KBKDF MAC update length against word32 truncation
d7714cb
@aidangarske
F-5202 - Guard KBKDF CMAC key length against word32 truncation
2515375
@aidangarske
F-4297 - Cap KBKDF output to the 32-bit SP800-108 L field
dc3f256
@aidangarske
F-5201 - Guard HMAC key length against word32 truncation
d231f84
@aidangarske
F-4295 - Guard HKDF derive lengths against word32 truncation
cf91480
@aidangarske
F-4296 - Guard TLS 1.3 HKDF expand lengths against word32 truncation
b251b28
@aidangarske
F-5203 - Reject PBKDF2 iteration count above INT_MAX
de63c52
@aidangarske
F-5180 - Guard PBKDF2 password, salt, and key lengths against int tru…
557e09b 
…ncation
@aidangarske
F-4383 - Guard AES-GCM input and AAD lengths against word32 truncation
5c625b2
@aidangarske
F-4939 - Guard AES-CCM input and AAD lengths against word32 truncation
dbaceb9
@aidangarske
F-4696 - Cap accumulated GMAC data length to avoid overflow and trunc…
cf58e42 
…ation
@aidangarske
F-5200 - Guard GMAC data and output lengths against word32 truncation
84d9a9d
@aidangarske
F-5915 - Guard AES key-wrap input and output lengths against truncation
b30b492
@aidangarske aidangarske self-assigned this Jul 10, 2026
Copilot AI review requested due to automatic review settings July 10, 2026 22:58
@aidangarske aidangarske marked this pull request as ready for review July 10, 2026 23:00
@aidangarske aidangarske added the ci:all PR OSP toggle: run all label Jul 10, 2026
Copilot AI reviewed Jul 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@aidangarske aidangarske added ci:all PR OSP toggle: run all and removed ci:all PR OSP toggle: run all labels Jul 13, 2026
@aidangarske

aidangarske commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

Jenkins retest this please

padelsbach
padelsbach requested changes Jul 13, 2026
View reviewed changes

@padelsbach padelsbach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, few questions/concerns

Comment thread src/wp_ecdh_exch.c Outdated
Comment thread src/wp_ecc_kmgmt.c Outdated
Comment thread src/wp_digests.c Outdated
Comment thread src/wp_rsa_sig.c
@padelsbach padelsbach assigned aidangarske and unassigned padelsbach Jul 13, 2026
@aidangarske aidangarske requested a review from padelsbach July 13, 2026 23:05
@padelsbach

padelsbach commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@aidangarske this has conflicts now that #438 has merged

@padelsbach padelsbach merged commit a3f50b7 into wolfSSL:master Jul 14, 2026
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@padelsbach padelsbach padelsbach approved these changes
@ColtonWilley ColtonWilley Awaiting requested review from ColtonWilley

Assignees

@padelsbach padelsbach

Labels

ci:all PR OSP toggle: run all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aidangarske @padelsbach