Conversation
Frauschi
force-pushed
the
pkcs11_pqc_prep
branch
4 times, most recently
from
588625d to
86ab969
Compare
dgarske
requested changes
Feb 5, 2026
Collaborator
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Is this expected to fail with v3.2 enabled?
./tests/pkcs11test
...
31: test_recover ...
tests/pkcs11test.c:5358 - Verify Recover not initialized RETURNED 70 - FAIL
32: test_verify_recover_pkcs ...
tests/pkcs11test.c:5446 - Verify recover: 70 - FAIL
33: test_verify_recover_x509 ...
tests/pkcs11test.c:5434 - Sign: 70 - FAIL
Frauschi
force-pushed
the
pkcs11_pqc_prep
branch
2 times, most recently
from
c0c5c44 to
dbe724f
Compare
Contributor
Author
|
I fixed the failing tests and added comments for the different versions. But the problem with the definitions for major and minor versions is still todo, as I haven't found a good solution yet to keep this file self-contained (without any includes) while also changing these values depending on the build. |
Collaborator
|
@Frauschi please resolve conflict. This looks good now. |
dgarske
previously approved these changes
Feb 6, 2026
Frauschi
force-pushed
the
pkcs11_pqc_prep
branch
from
dbe724f to
1906949
Compare
Contributor
Author
Done. Should be ready now |
SparkiDev
approved these changes
Feb 10, 2026
dgarske
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds initial work to ultimately support PQC via PKCS#11. For that to work, the PKCS#11 interface has to be upgraded to Version 3.2.
Actually in this PR:
C_GetInterfacefunctionality to load the library.All the new functions from version 3.0 and 3.2 are not filled with logic currently and return
CKR_FUNCTION_NOT_SUPPORTED. Adding actual support for all the newC_EncryptMessage()etc. functions similarly to the existingC_Encrypt()etc. would be pretty thorough work, which is not the focus of the current endeavor.Once this work is merged, follow up PRs add the actual functionality for the PQC algorithms (initially ML-KEM and ML-DSA, LMS and XMSS later).