Conversation
- Replace esp-web-tools@10.1.0 with tasmota-esp-web-tools@12.2.1 (Jason2866's fork), which detects device flash size at runtime and selects the best matching firmware build via the flashSizeMB manifest field - Split the single ESP32-S3 CHIP_CONFIG entry into three (4MB/8MB/16MB), each pointing to the correct partition table binary - Add VARIANTS entries for _ESP32-S3_4M_qspi and _ESP32-S3_16MB_opi alongside the existing _ESP32-S3_8MB_opi; generateManifest now emits flashSizeMB on every S3 build object - Add partitions_s3_4m.bin and partitions_s3_16m.bin (compiled from WLED's WLED_ESP32_4MB_1MB_FS.csv and WLED_ESP32_16MB_9MB_FS.csv) - Remove all static manifest files from bin/Release, bin/Beta and bin/nightly; the dropdown is now fully populated from the GitHub Releases API
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I'm unsure exactly which combinations we need to test, however if what I do know is that the current installer just gives every S3 the 8MB image, which means the S3 zero will fail to boot, that needs the 4MB I can see that if I connect my 16MB it tries to give me the 16MB image, I haven't done a full install as the corsfix thing prevents the actual install |
1 participant
This pull request introduces several updates to improve device compatibility and simplify the user interface for the WLED web installer. The most significant changes include adding support for multiple ESP32-S3 flash sizes, updating the installer button to use a forked version of ESP Web Tools, and streamlining the release selection dropdown for a better user experience.
Device compatibility improvements:
releases.js, including appropriate boot partition files and firmware naming conventions for each variant. This enables automatic detection and correct firmware selection for different S3 hardware. [1] [2]releases.jsto include theflashSizeMBproperty for ESP32-S3 variants, ensuring the installer can select the correct build based on detected flash size.Installer and UI updates:
index.htmto use thetasmota-esp-web-toolsfork, which supports the new S3 flash size detection and selection logic.index.htmto display a loading message, likely in preparation for dynamic population of releases.Cleanup:
auto.htmfile, which previously provided a maintenance overlay and an alternative installer link.