WPB-23942 prevent rabbit mq queues creation for client notifications#5116
Open
battermann wants to merge 11 commits intodevelopfrom
Open
WPB-23942 prevent rabbit mq queues creation for client notifications#5116battermann wants to merge 11 commits intodevelopfrom
battermann wants to merge 11 commits intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes “consumable notifications” (RabbitMQ-backed client notifications) configurable and disables the RabbitMQ queue setup/publishing paths by default, to prevent unintended queue creation for client notifications.
Changes:
- Add a new
consumableNotificationsboolean setting to Brig and Gundeck configs and propagate it via Helm/integration YAML. - Gate RabbitMQ queue setup for consumable-notification clients (Brig + Gundeck internal endpoint) and gate RabbitMQ routing in Gundeck push processing.
- Update integration tests to explicitly enable consumable notifications when exercising that functionality.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| services/gundeck/test/unit/MockGundeck.hs | Implements new MonadPushAll capability flag in the mock. |
| services/gundeck/src/Gundeck/Push.hs | Adds mpaConsumableNotificationsEnabled and gates RabbitMQ split/routing. |
| services/gundeck/src/Gundeck/Options.hs | Adds settings.consumableNotifications to Gundeck settings schema. |
| services/gundeck/src/Gundeck/API/Internal.hs | Prevents queue setup calls when consumable notifications are disabled. |
| services/gundeck/gundeck.integration.yaml | Sets settings.consumableNotifications: false for integration config. |
| services/brig/src/Brig/Options.hs | Adds optSettings.setConsumableNotifications to Brig settings schema. |
| services/brig/src/Brig/API/Client.hs | Gates setupConsumableNotifications on the new Brig setting. |
| services/brig/brig.integration.yaml | Sets optSettings.setConsumableNotifications: false for integration config. |
| integration/test/Test/Events.hs | Enables consumable notifications via overrides in tests that depend on it. |
| hack/helm_vars/wire-server/values.yaml.gotmpl | Introduces CI helm values knob consumableNotifications: false. |
| hack/bin/helm-render-ci-values.sh | Adds helper script to render CI values via helmfile. |
| charts/wire-server/values.yaml | Adds top-level Helm value consumableNotifications: false. |
| charts/wire-server/templates/gundeck/configmap.yaml | Wires Helm value into Gundeck settings.consumableNotifications. |
| charts/wire-server/templates/brig/configmap.yaml | Wires Helm value into Brig optSettings.setConsumableNotifications. |
| changelog.d/5-internal/WPB-23942 | Adds changelog entry for configurability/default disable. |
| Makefile | Adds render-ci-manifest target to render CI manifest from rendered values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 18 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-23942
Checklist
changelog.d