WPB-23441 fix: validate saml emails feature not correctly targeted#5114
Merged
battermann merged 5 commits intodevelopfrom Mar 12, 2026
Merged
Conversation
akshaymankar
changed the title
zebot
added
the
ok-to-test
blackheaven
requested changes
Mar 11, 2026
blackheaven
approved these changes
Mar 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes targeting of the validateSAMLemails team feature flag by standardizing on the canonical key while attempting to keep backward compatibility with the legacy typo in configuration/Helm inputs.
Changes:
- Add a custom
ParseFeatureDefaultsinstance forValidateSAMLEmailsConfigto accept both the canonical key and the legacy typo. - Update integration tests, docs, and Helm chart values/templates to use/render
validateSAMLemails(with Helm accepting the legacy typo as fallback). - Add a changelog entry for the fix.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| libs/wire-api/src/Wire/API/Team/FeatureFlags.hs | Custom parsing for validateSAMLemails defaults intended to support legacy typo input. |
| integration/test/Test/Spar/STM.hs | Update feature flag key used by tests to validateSAMLemails. |
| integration/test/Test/Auth.hs | Update feature flag key used by tests to validateSAMLemails. |
| docs/src/developer/reference/config-options.md | Document canonical validateSAMLemails key in config example. |
| charts/wire-server/values.yaml | Rename Helm values key to validateSAMLemails. |
| charts/wire-server/templates/galley/configmap.yaml | Render canonical Galley key while accepting legacy Helm values key as fallback. |
| changelog.d/3-bug-fixes/WPB-23441 | Changelog entry for the fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
battermann
deleted the
WPB-23441-validate-sam-lemails-feature-not-correctly-targeted
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-23441
Checklist
changelog.d