docs: remove non-dismissible documentation notification bar#7746
Merged
alexander-akait merged 2 commits intowebpack:mainfrom Jan 19, 2026
Merged
docs: remove non-dismissible documentation notification bar#7746alexander-akait merged 2 commits intowebpack:mainfrom
alexander-akait merged 2 commits intowebpack:mainfrom
Conversation
|
@pranjalisr is attempting to deploy a commit to the OpenJS Foundation Team on Vercel. A member of the Team first needs to authorize it. |
| __webpack_public_path__ = self.location.origin + '/assets/'; | ||
|
|
||
| // Then import or execute the rest of your worker logic | ||
| importScripts('deep-thought.js'); |
Contributor
Author
There was a problem hiding this comment.
Thanks for the review!
These lines were carried over from my earlier PR. I’ve removed them from this one. Please let me know if further adjustments are needed.
| </> | ||
| ); | ||
| return null; | ||
| } |
Member
There was a problem hiding this comment.
Why we need this component at all?
Contributor
Author
There was a problem hiding this comment.
Agreed — it’s no longer needed. I’ve removed the NotificationBar completely along with all related files and references. The notifier is no longer part of the codebase at all. Please take another look and let me know if any other change is required.
alexander-akait
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the global documentation notification bar that informs users they are viewing a different documentation version. Fixes issue #7737
The notification cannot be dismissed in Firefox, blocks essential parts of the page, and relies on non-semantic interaction patterns (div role="button"). While a close button is rendered in Chrome, it does not appear in Firefox, causing the banner to reappear on every page load and negatively impact usability and accessibility.
Given that the notification is rendered globally and provides no actionable value, the component has been turned into a no-op to fully remove the problematic UI without touching layout wiring or introducing browser-specific logic.
What kind of change does this PR introduce?
Fix / Docs
Did you add tests for your changes?
No.
This change removes a purely presentational UI component from the documentation site. There is no business logic or functional behavior to test, and the repository does not currently include tests covering documentation UI banners.
Does this PR introduce a breaking change?
No.
The change only affects the documentation UI and does not impact Webpack functionality, APIs, or consumer applications.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
No additional documentation is required. The notification has been removed entirely rather than replaced or modified.