-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: remove SockJS support #5626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #5626 +/- ##
=======================================
Coverage 83.56% 83.57%
=======================================
Files 13 11 -2
Lines 2050 1966 -84
Branches 755 736 -19
=======================================
- Hits 1713 1643 -70
+ Misses 303 290 -13
+ Partials 34 33 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
012357a to
a181f84
Compare
|
@bjohansebas If you will need a help feel free to ping me |
fc88df5 to
258907d
Compare
2b2d4d9 to
847d2ed
Compare
|
I don’t understand why macOS and Windows are failing. |
|
@bjohansebas Looks like racing in tests... macos works fine, windows doesn't, do I need to look deeply? |
yes, please! |
Signed-off-by: Sebastian Beltran <[email protected]>
…nd package-lock.json
cba7428 to
110afee
Compare
|
Hmm, it’s still happening even after updating Puppeteer. I’m still investigating. |
4fc0ee9 to
924e9ed
Compare
|
@bjohansebas I think it is just unstable test maybe we need to rewrite this test |
924e9ed to
6410704
Compare
|
Okay, I did it, i got it working. Ready for review. |
alexander-akait
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge
Summary
This removes SockJS, which was used to maintain compatibility with older browsers, but is no longer necessary
What kind of change does this PR introduce?
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
yes
If relevant, what needs to be documented once your changes are merged or what have you already documented?