-
-
Notifications
You must be signed in to change notification settings - Fork 382
fix: update getFilenameFromUrl to return errorCode and filename #2253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2253 +/- ##
==========================================
- Coverage 95.85% 95.67% -0.19%
==========================================
Files 13 13
Lines 892 901 +9
Branches 260 263 +3
==========================================
+ Hits 855 862 +7
- Misses 37 39 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Moving back to draft because we need to use |
85bcecc to
f56758e
Compare
|
Okay, for now one test is failing. When |
f56758e to
d3d6299
Compare
|
Refactored to use |
|
Also I am thinking about union parse url and publicPath, less calls and faster, but we need extra checks here, all possible values - https://webpack.js.org/configuration/output/#outputpublicpath + broken cases |
Summary
I’m removing this TODO that was there. I still need to investigate whether the next TODO actually exists and fix it if so. Now that it returns other things, I think we should change the name, what do you think?
What kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?