Fix client schema deprecated input values#1945
Open
simPod wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Preserves deprecationReason for input values (field arguments and input object fields) when rebuilding a client schema from introspection via BuildClientSchema, so that deprecated input values remain deprecated when the client schema is printed back to SDL.
Changes:
- Include
deprecationReasonwhen constructing input value configs inBuildClientSchema::buildInputValue(). - Extend the deprecation round-trip test to cover deprecated input object fields and deprecated field arguments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Utils/BuildClientSchema.php |
Ensures deprecationReason from introspection is preserved for input values built into the client schema. |
tests/Utils/BuildClientSchemaTest.php |
Adds coverage for deprecated input fields and deprecated arguments in the introspection → client schema → introspection cycle. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve
deprecationReasonwhen rebuilding input values from introspection inBuildClientSchema.This keeps deprecated field arguments and input object fields available when a client schema is printed back to SDL.