Skip to content

Clarify warpctrl admin install fallback#12838

Open
zachlloyd wants to merge 1 commit into
masterfrom
zach/warpctrl-iteration
Open

Clarify warpctrl admin install fallback#12838
zachlloyd wants to merge 1 commit into
masterfrom
zach/warpctrl-iteration

Conversation

@zachlloyd

@zachlloyd zachlloyd commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Description

Updates the bundled Warp Control skill's installation fallback to invoke an explicit, argument-safe osascript command when /usr/local/bin requires elevated permissions. This produces the standard macOS administrator dialog, avoids asking agents to use sudo or handle passwords, and treats cancellation as declining installation while continuing with the bundled wrapper.

Linked Issue

No linked issue.

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

  • Compiled the AppleScript fallback with osacompile without executing it.

  • Ran git diff --check.

  • Ran ./script/format.

  • Ran cargo clippy --workspace --all-targets --all-features --tests -- -D warnings.

  • I have manually tested my changes locally with ./script/run

Screenshots / Videos

Not applicable; this changes bundled skill instructions.

Agent Mode

CHANGELOG-NONE

Co-Authored-By: Oz oz-agent@warp.dev

Co-Authored-By: Oz <oz-agent@warp.dev>
@cla-bot cla-bot Bot added the cla-signed label Jun 19, 2026
@oz-for-oss

oz-for-oss Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@zachlloyd

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR clarifies the bundled Warp Control skill's /usr/local/bin install fallback by replacing the vague elevated-permissions instruction with an explicit osascript command that quotes both path arguments and relies on the standard macOS administrator dialog.

Concerns

  • No blocking correctness, security, or spec-alignment concerns found in the attached diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant