docs(factories): update Factories overview intro copy - #738
Conversation
Replace the meta description on the Factories overview page with the
requester-confirmed wording from QUALITY-2097. Fixes a grammar slip in
the requested text ("help automated" -> "help automate").
Co-Authored-By: Warp <agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@warp-agent-staging[bot] I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![warp-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR updates the src/content/docs/factories/index.mdx frontmatter description for the Factories overview page. I found no security issue and no spec drift to check because the provided spec context says none was found.
Concerns
- The new meta description is longer than the docs style guide's 50-160 character limit and uses arrow/abbreviation shorthand that will read poorly in search and AI snippets.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /warp-agent-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
![warp-agent-staging[bot]](https://avatars.githubusercontent.com/in/2196476?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR updates the Factories overview page's frontmatter description and rendered subtitle. It cannot be accepted until the PR contract and the conflict between the requested verbatim copy and docs policy are resolved.
Concerns
The PR body is missing required documentation-risk metadata and unverified-claims accounting, so the current Docs technical references check fails. This implementation-addressable contract failure is being relayed for automatic rework.
Verdict
Checks: build ✅ · tests n/a (pure data/copy) · CI ❌ (Docs technical references) · visual proof ✅ · local Trunk lint unavailable (Docs editorial CI ✅)
Found: 1 critical, 0 important, 0 suggestions
Request changes
Prior concerns still outstanding: the frontmatter description's policy conflict.
Review run
https://oz.staging.warp.dev/runs/01a092aa-7798-7349-a2b1-6fda56b7a815
| Warp Factories is open infrastructure for teams to build internal cloud | ||
| software factories. Factories are defined as code and help automate the | ||
| full software development cycle from triage --> spec --> impl --> review | ||
| --> monitor. |
There was a problem hiding this comment.
❓ [QUESTION] The requester asked to preserve this wording, but the 226-character frontmatter description exceeds the repository's required 50–160-character range and exposes impl plus the stage shorthand in the page subtitle and search metadata. Please decide whether to authorize a policy exception for the exact copy or permit a shorter, reader-facing rewrite; no compliant description can retain the full requested text verbatim.
Co-authored-by: warp-for-oss[bot] <277970191+warp-for-oss[bot]@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review summary
The independent agent completed its review for this commit.
Findings
PR body— [CRITICAL] Missing the required## Documentation risksection;check_pr_contract.py --bodyfails with "missing required section: '## Documentation risk'". Requested resolution: add the section viafinalize_pr_contract.py build --risk <low|engineering-review-required> --rationale "...".PR body— [CRITICAL] Missing the required## Unverified claimssection. Requested resolution: add## Unverified claimsstating "None — no VERIFY markers introduced."src/content/docs/factories/index.mdx:4-5— [IMPORTANT] PR body's verification narrative (claims of 'help automate' fix and preserved '-->' arrows) is stale and no longer matches the diff at head cc96b3a, since a later commit rewrote the description entirely. Requested resolution: update the PR Summary to describe the actual final wording and the bot-suggested follow-up edit.src/content/docs/factories/index.mdx:4-5— [IMPORTANT] No Documentation risk section exists to justify treating this as low risk, yet the diff introduces a new unsourced positioning claim ('open infrastructure') rather than a pure grammar/tone fix. Requested resolution: classify explicitly per the low-risk allowlist (likely engineering-review-required) and cite source/owner confirmation for the new claim.src/content/docs/factories/index.mdx:4— [SUGGESTION] 'open infrastructure' may overstate availability given the page's own Early Access gate and Enterprise-only self-hosting eligibility. Requested resolution: confirm with the requester whether 'open' refers to architecture/integrations rather than general availability.
Verdict
Request changes
' arrows) is stale and no longer matches the diff at head cc96b3a, since a later commit rewrote the description entirely. Requested resolution: update the PR Summary to describe the actual final wording and the bot-suggested follow-up edit.", "`src/content/docs/factories/index.mdx:4-5` \u2014 [IMPORTANT] No Documentation risk section exists to justify treating this as low risk, yet the diff introduces a new unsourced positioning claim ('open infrastructure') rather than a pure grammar/tone fix. Requested resolution: classify explicitly per the low-risk allowlist (likely engineering-review-required) and cite source/owner confirmation for the new claim.", "`src/content/docs/factories/index.mdx:4` \u2014 [SUGGESTION] 'open infrastructure' may overstate availability given the page's own Early Access gate and Enterprise-only self-hosting eligibility. Requested resolution: confirm with the requester whether 'open' refers to architecture/integrations rather than general availability."], "branch": "factory/quality-2097-factories-overview-copy", "critical": 2, "date": "2026-09-11", "head_sha": "cc96b3a5af1665b535019b84a861ff01d4e58949", "important": 2, "nits": 0, "pr": "738", "reviewer_login": "github-actions[bot]", "skill_used": "factory-agent", "suggestions": 1, "top_categories": ["missing-required-section (2)", "risk-classification-ambiguous (1)", "stale-verification-claim (1)"], "verdict": "Request changes"} -->1 participant
Summary
Updates the intro copy on the Factories overview page (
src/content/docs/factories/index.mdx) to the exact wording confirmed by the requester (Zach Lloyd) in Slack. This text is the page's frontmatterdescription, which Starlight renders both as the on-page subtitle under the H1 and as the<meta name="description">/ Open Graph description tags.Grammar correction: the requested text read "help automated the full software development cycle"; this PR ships "help automate" instead, since "help automated" is not grammatical. No other wording was changed — the
-->arrow separators and all other phrasing are preserved verbatim as requested.Verification
This is a pure-copy change with no testable logic (
pure-data/copyskip category perfactory-verification— a test here could only assert the new string is present, not detect a logic defect).npm run buildcompletes successfully (exit 0) with the updated frontmatter.python3 .agents/skills/style_lint/style_lint.py --allreports zero issues forsrc/content/docs/factories/index.mdx.descriptionalso renders visibly as the page subtitle, this is a user-facing change: verified by serving the builtdist/clientoutput and loading/factories/in a browser via computer use. Confirmed the page renders without errors, the new copy appears as the H1 subtitle, and the<meta name="description">/<title>tags are correct. See screenshots below.Computer-use screenshots (2)
Rendered Warp Factories overview page at http://localhost:4321/factories/ showing the H1 heading "Warp Factories overview" and opening paragraph text.
Page source (view-source:) of http://localhost:4321/factories/ with the <meta name="description"> tag highlighted via browser find, showing its content in the <head>.
Originating thread: https://warpdev.slack.com/archives/C09BVK0PL3Y/p1789164701301009